Conversation
googlebot
added
the
cla: yes
lesv
reviewed
Feb 15, 2018
| # Check for changes to the current folder | ||
| if [ "$RTN" -eq 1 ]; then | ||
| echo -e "\n Change detected. Running tests. \n " | ||
| if [ "$CHANGED" -eq 1 ] && [ "$PARENT" -eq 0 ]; then |
lesv
approved these changes
Feb 15, 2018
Contributor
lesv
left a comment
lesv
left a comment
There was a problem hiding this comment.
you might wish to try shellcheck on the fille. It's a shell linter. I think our styleguide for bash requires quoted and ${...}, but shellcheck will know for sure. I'm also ok if you merge.
Contributor
Author
|
@lesv I going to go ahead and pull it for now, but I'll talk with Dane about running shellcheck on it in the future as part of the tests. |
Shabirmean
pushed a commit
that referenced
this pull request
Nov 14, 2022
…#1030) [](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [com.google.cloud:google-cloud-core](https://togithub.com/googleapis/java-core) | `2.8.19` -> `2.8.20` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>googleapis/java-core</summary> ### [`v2.8.20`](https://togithub.com/googleapis/java-core/blob/HEAD/CHANGELOG.md#​2820-httpsgithubcomgoogleapisjava-corecomparev2819v2820-2022-10-02) [Compare Source](https://togithub.com/googleapis/java-core/compare/v2.8.19...v2.8.20) ##### Dependencies - Update dependency com.google.api:gax-bom to v2.19.2 ([#​969](https://togithub.com/googleapis/java-core/issues/969)) ([1151449](https://togithub.com/googleapis/java-core/commit/1151449c061ab51c45982444db5f9da9d2ce4fb7)) - Update dependency com.google.api.grpc:proto-google-common-protos to v2.9.6 ([#​967](https://togithub.com/googleapis/java-core/issues/967)) ([4a7b524](https://togithub.com/googleapis/java-core/commit/4a7b524fa366484825bedbc0a4f86d4551a6a0e8)) - Update dependency io.grpc:grpc-bom to v1.49.2 ([#​966](https://togithub.com/googleapis/java-core/issues/966)) ([b7738aa](https://togithub.com/googleapis/java-core/commit/b7738aa71fb9cf0994e4ad1dae4bae433754cda0)) </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, click this checkbox. --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/java-dialogflow). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzMi4yMTMuMCIsInVwZGF0ZWRJblZlciI6IjMyLjIxMy4xIn0=-->
9 tasks
Shabirmean
pushed a commit
that referenced
this pull request
Nov 15, 2022
](https://renovatebot.com){kind=link}
…#1030) [](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [com.google.cloud:google-cloud-core](https://togithub.com/googleapis/java-core) | `2.8.19` -> `2.8.20` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>googleapis/java-core</summary> ### [`v2.8.20`](https://togithub.com/googleapis/java-core/blob/HEAD/CHANGELOG.md#​2820-httpsgithubcomgoogleapisjava-corecomparev2819v2820-2022-10-02) [Compare Source](https://togithub.com/googleapis/java-core/compare/v2.8.19...v2.8.20) ##### Dependencies - Update dependency com.google.api:gax-bom to v2.19.2 ([#​969](https://togithub.com/googleapis/java-core/issues/969)) ([1151449](https://togithub.com/googleapis/java-core/commit/1151449c061ab51c45982444db5f9da9d2ce4fb7)) - Update dependency com.google.api.grpc:proto-google-common-protos to v2.9.6 ([#​967](https://togithub.com/googleapis/java-core/issues/967)) ([4a7b524](https://togithub.com/googleapis/java-core/commit/4a7b524fa366484825bedbc0a4f86d4551a6a0e8)) - Update dependency io.grpc:grpc-bom to v1.49.2 ([#​966](https://togithub.com/googleapis/java-core/issues/966)) ([b7738aa](https://togithub.com/googleapis/java-core/commit/b7738aa71fb9cf0994e4ad1dae4bae433754cda0)) </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, click this checkbox. --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/java-dialogflow). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzMi4yMTMuMCIsInVwZGF0ZWRJblZlciI6IjMyLjIxMy4xIn0=-->
Sita04
pushed a commit
that referenced
this pull request
Feb 7, 2023
…1.3 (#1030) [](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [com.google.cloud:libraries-bom](https://cloud.google.com/java/docs/bom) ([source](https://togithub.com/googleapis/java-cloud-bom)) | `26.1.2` -> `26.1.3` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Renovate will not automatically rebase this PR, because other commits have been found. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, click this checkbox. ⚠ **Warning**: custom changes will be lost. --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/java-dlp). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzMi4yMTkuMSIsInVwZGF0ZWRJblZlciI6IjMyLjIxOS4xIn0=-->
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes diff tests to only output for projects tested to reduce noise, and fixes so that only leaf projects are run.