Skip to content

Commit c8e4c6e

Browse files
Added return value for CreateQueuedResource
1 parent 03dc783 commit c8e4c6e

File tree

2 files changed

+5
-8
lines changed

2 files changed

+5
-8
lines changed

tpu/src/main/java/tpu/CreateQueuedResource.java

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -55,7 +55,7 @@ public static void main(String[] args)
5555
}
5656

5757
// Creates a Queued Resource
58-
public static void createQueuedResource(String projectId, String zone,
58+
public static QueuedResource createQueuedResource(String projectId, String zone,
5959
String queuedResourceId, String nodeName, String tpuType, String tpuSoftwareVersion)
6060
throws IOException, ExecutionException, InterruptedException {
6161
// With these settings the client library handles the Operation's polling mechanism
@@ -116,6 +116,7 @@ public static void createQueuedResource(String projectId, String zone,
116116
// You can wait until TPU Node is READY,
117117
// and check its status using getTpuVm() from "tpu_vm_get" sample.
118118
System.out.printf("Queued Resource created: %s\n", response.getName());
119+
return response;
119120
}
120121
}
121122
}

tpu/src/test/java/tpu/QueuedResourcesIT.java

Lines changed: 3 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -93,15 +93,11 @@ public static void cleanup() throws IOException {
9393
@Order(1)
9494
public void testCreateQueuedResource()
9595
throws IOException, ExecutionException, InterruptedException {
96-
final PrintStream out = System.out;
97-
ByteArrayOutputStream stdOut = new ByteArrayOutputStream();
98-
System.setOut(new PrintStream(stdOut));
99-
CreateQueuedResource.createQueuedResource(PROJECT_ID, ZONE,
96+
QueuedResource queuedResource = CreateQueuedResource.createQueuedResource(PROJECT_ID, ZONE,
10097
QUEUED_RESOURCE_NAME, NODE_NAME, TPU_TYPE, TPU_SOFTWARE_VERSION);
10198

102-
assertThat(stdOut.toString()).contains("Queued Resource created: " + QUEUED_RESOURCE_PATH_NAME);
103-
stdOut.close();
104-
System.setOut(out);
99+
assertThat(queuedResource.getName()).isEqualTo(QUEUED_RESOURCE_PATH_NAME);
100+
assertThat(queuedResource.getTpu().getNodeSpec(0).getNode().getName()).isEqualTo(NODE_NAME);
105101
}
106102

107103
@Test

0 commit comments

Comments
 (0)