Skip to content

feat(gcp): current region methods #399

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions gcp/lib/gcp.dart
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,12 @@ export 'src/gcp_project.dart'
gcpProjectIdEnvironmentVariables,
projectIdFromEnvironment,
projectIdFromMetadataServer;
export 'src/gpc_region.dart'
show
computeRegion,
gcpRegionEnvironmentVariables,
regionFromEnvironment,
regionFromMetadataServer;
export 'src/log_severity.dart' show LogSeverity, RequestLogger;
export 'src/logging.dart'
show
Expand Down
104 changes: 104 additions & 0 deletions gcp/lib/src/gpc_region.dart
Original file line number Diff line number Diff line change
@@ -0,0 +1,104 @@
// Copyright 2022 Google LLC
//
// Licensed under the Apache License, Version 2.0 (the "License");
// you may not use this file except in compliance with the License.
// You may obtain a copy of the License at
//
// http://www.apache.org/licenses/LICENSE-2.0
//
// Unless required by applicable law or agreed to in writing, software
// distributed under the License is distributed on an "AS IS" BASIS,
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
// See the License for the specific language governing permissions and
// limitations under the License.

import 'dart:io';

import 'package:http/http.dart' as http;

import 'bad_configuration_exception.dart';

/// A convenience wrapper that first tries [regionFromEnvironment]
/// then (if the value is `null`) tries [regionFromMetadataServer]
///
/// Like [regionFromMetadataServer], if no value is found, a
/// [BadConfigurationException] is thrown.
Future<String> computeRegion() async {
final localValue = regionFromEnvironment();
if (localValue != null) {
return localValue;
}
final result = await regionFromMetadataServer();

return result;
}

/// Returns the
/// [Region](https://cloud.google.com/compute/docs/regions-zones#identifying_a_region_or_zone)
/// for the current instance by checking the environment variables
/// in [gcpRegionEnvironmentVariables].
///
/// The list is checked in order. This is useful for local development.
///
/// If no matching variable is found, `null` is returned.
String? regionFromEnvironment() {
for (var envKey in gcpRegionEnvironmentVariables) {
final value = Platform.environment[envKey];
if (value != null) return value;
}

return null;
}

/// Returns a [Future] that completes with the
/// [Region](https://cloud.google.com/compute/docs/regions-zones#identifying_a_region_or_zone)
/// for the current instance by checking
/// [instance metadata](https://cloud.google.com/compute/docs/metadata/default-metadata-values#vm_instance_metadata).
///
/// If the metadata server cannot be contacted, a [BadConfigurationException] is
/// thrown.
Future<String> regionFromMetadataServer() async {
const host = 'http://metadata.google.internal/';
final url = Uri.parse('$host/computeMetadata/v1/instance/region');
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should DRY up this logic. Maybe add a metadata_server.dart file and share the logic with gcp_project.dart?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@prefanatic thoughts on my thoughts?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kevmoo Sorry about the delay - I took a few stabs at drying up this implementation, but didn't like the direction I found myself in.

One attempt at buttoning this up included defining MetadataServerClient (name withstanding) which exposed these region and project endpoints. However, I was unhappy with aspects related to error handling; we disclose some nice resolution regarding which environment variables to provide in leu of the metadata server. It felt weird to me to move that into such a metadata_server.dart.

In an attempt with leaving the error handling out, I ended up with an implementation that's slightly analogous to http.read, where computeRegion and computeProject would open up a client, try and return the metadata result, or catch into statement about environment variables needed. This slimmed up the original methods a little bit, but now introduced some arguably duplicative withClient semantics to retain backwards compatibility in those methods.

I think this approach is worth taking? Let me know if I'm on the right track.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What do you think of this? #421

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, looks much nicer. I wish I thought of using enhanced enums!

I left some small documentation nits over there for the generalization, in the review.


try {
final response = await http.get(
url,
headers: {'Metadata-Flavor': 'Google'},
);

if (response.statusCode != 200) {
throw HttpException(
'${response.body} (${response.statusCode})',
uri: url,
);
}

return response.body;
} on SocketException catch (e) {
throw BadConfigurationException(
'''
Could not connect to $host.
If not running on Google Cloud, one of these environment variables must be set
to the target region:
${gcpRegionEnvironmentVariables.join('\n')}
''',
details: e.toString(),
);
}
}

/// A set of typical environment variables that are likely to represent the
/// current Google Cloud instance region.
///
/// For context, see:
/// * https://cloud.google.com/functions/docs/env-var
/// * https://cloud.google.com/compute/docs/gcloud-compute#default_project
/// * https://github.com/GoogleContainerTools/gcp-auth-webhook/blob/08136ca171fe5713cc70ef822c911fbd3a1707f5/server.go#L38-L44
///
/// Note: these are ordered starting from the most current/canonical to least.
/// (At least as could be determined at the time of writing.)
const gcpRegionEnvironmentVariables = {
'FUNCTION_REGION',
'CLOUDSDK_COMPUTE_REGION',
};
32 changes: 32 additions & 0 deletions gcp/test/gcp_test.dart
Original file line number Diff line number Diff line change
Expand Up @@ -131,6 +131,38 @@ void main() {
});
},
);

group('currentRegion', () {
const regionPrint = 'test/src/region_print.dart';

test('not environment', () async {
final proc = await _run(regionPrint);

final errorOut = await proc.stderrStream().toList();

await expectLater(
errorOut,
containsAll(gcpRegionEnvironmentVariables),
);
await expectLater(proc.stdout, emitsDone);

await proc.shouldExit(255);
});

test('environment set', () async {
final proc = await _run(
regionPrint,
environment: {gcpRegionEnvironmentVariables.first: 'us-central1'},
);

await expectLater(proc.stdout, emits('us-central1'));
await expectLater(proc.stderr, emitsDone);

await proc.shouldExit(0);
});

// TODO: worth emulating the metadata server?
});
}

Future<TestProcess> _run(
Expand Down
18 changes: 18 additions & 0 deletions gcp/test/src/region_print.dart
Original file line number Diff line number Diff line change
@@ -0,0 +1,18 @@
// Copyright 2022 Google LLC
//
// Licensed under the Apache License, Version 2.0 (the "License");
// you may not use this file except in compliance with the License.
// You may obtain a copy of the License at
//
// http://www.apache.org/licenses/LICENSE-2.0
//
// Unless required by applicable law or agreed to in writing, software
// distributed under the License is distributed on an "AS IS" BASIS,
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
// See the License for the specific language governing permissions and
// limitations under the License.
import 'package:gcp/gcp.dart';

Future<void> main() async {
print(await computeRegion());
}