Issue 15 - Use a HashSessionManager/HashSessionIdManager if sessions are disabled.

Author: janbartel

appengine-jetty-managed-runtime/src/main/java/com/google/apphosting/runtime/jetty9/SessionManager.java

@@ -25,9 +25,12 @@
 import com.google.apphosting.runtime.SessionData;
 import com.google.apphosting.runtime.SessionStore;
 
+import org.eclipse.jetty.server.Server;
+import org.eclipse.jetty.server.SessionIdManager;
 import org.eclipse.jetty.server.session.AbstractSession;
 import org.eclipse.jetty.server.session.AbstractSessionManager;
 import org.eclipse.jetty.server.session.HashSessionIdManager;
+import org.eclipse.jetty.util.component.LifeCycle.Listener;
 
 import java.io.PrintWriter;
 import java.io.StringWriter;
@@ -44,6 +47,7 @@
 import java.util.logging.Logger;
 
 import javax.servlet.http.HttpServletRequest;
+import javax.servlet.http.HttpSession;
 
 /**
  * Implements the Jetty {@link AbstractSessionManager} and, as an
@@ -322,8 +326,6 @@ static String lastId() {
    */
   public SessionManager(List<SessionStore> sessionStoresInWriteOrder) {
     super();
-    // Ludo: prefer to do this outside of the constructor.
-    setSessionIdManager(new SessionIdManager());
     this.sessionStoresInWriteOrder = sessionStoresInWriteOrder;
     // We'll always read in the opposite order we write, so create a copy
     // of the stores in write order and then reverse it.
@@ -418,7 +420,22 @@ private LogRecord createWarningLogRecord(String message, Throwable ex) {
             stringWriter.toString());
   }
 
+
+
+
+
   @Override
+  public void doStart() throws Exception {
+  	// always use our special id manager one
+  	System.err.println("Using special session id manager");
+  	_sessionIdManager = new SessionIdManager();
+  	_sessionIdManager.start();
+  	addBean(_sessionIdManager,true);
+
+  	super.doStart();
+  }
+
+@Override
   protected void addSession(AbstractSession session) {
     // No list of sessions is kept in memory, so do nothing here.
   }

appengine-jetty-managed-runtime/src/main/java/com/google/apphosting/vmruntime/jetty9/VmRuntimeWebAppContext.java

@@ -49,6 +49,7 @@
 import org.eclipse.jetty.security.ConstraintSecurityHandler;
 import org.eclipse.jetty.server.Request;
 import org.eclipse.jetty.server.session.AbstractSessionManager;
+import org.eclipse.jetty.server.session.HashSessionManager;
 import org.eclipse.jetty.server.session.SessionHandler;
 import org.eclipse.jetty.util.resource.Resource;
 import org.eclipse.jetty.webapp.WebAppContext;
@@ -245,10 +246,8 @@ public void init(String appengineWebXmlFile)
     AbstractSessionManager sessionManager;
     if (appEngineWebXml.getSessionsEnabled()) {
       sessionManager = new SessionManager(createSessionStores(appEngineWebXml));
-    } else {
-      sessionManager = new StubSessionManager();
+      getSessionHandler().setSessionManager(sessionManager);
     }
-    setSessionHandler(new SessionHandler(sessionManager));
   }
 
   @Override