-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Add integration tests to live spanner migration for checking PostgreSQL data type support #3152
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Summary of ChangesHello @nmemond, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly enhances the testing framework for the 'DataStreamToSpanner' Flex template by introducing dedicated integration tests for PostgreSQL data type migration. The tests are designed to validate how various PostgreSQL data types are mapped and transferred to both standard and PostgreSQL dialect Spanner databases during a live migration. This ensures the reliability and correctness of data transformations, with a pragmatic approach to handle currently unsupported types without blocking the test suite. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3152 +/- ##
============================================
+ Coverage 50.78% 54.74% +3.96%
+ Complexity 5103 2241 -2862
============================================
Files 975 490 -485
Lines 59984 28431 -31553
Branches 6552 2994 -3558
============================================
- Hits 30461 15565 -14896
+ Misses 27380 11921 -15459
+ Partials 2143 945 -1198
🚀 New features to boost your workflow:
|
...st/java/com/google/cloud/teleport/v2/templates/PostgreSQLDatastreamToSpannerDataTypesIT.java
Outdated
Show resolved
Hide resolved
|
Failure in asserts |
...st/java/com/google/cloud/teleport/v2/templates/PostgreSQLDatastreamToSpannerDataTypesIT.java
Outdated
Show resolved
Hide resolved
1505c37 to
b720ad6
Compare
|
There seems to be a Assert in matching
|
This adds integration tests to check data type mappings when doing a live migration from PostgreSQL to Spanner for both dialects.
Note that some of the type mappings fail to migrate as expected. The checks for those are still included for completeness, but they're ignored to avoid failing the tests.