This repository was archived by the owner on Nov 11, 2022. It is now read-only.
[BEAM-359] Treat erased type variables as non-deterministic in AvroCoder #531
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for this contribution, merging. This change will be available in If we make another release in the 1.x series, it will be included there, but this is not yet planned. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a back port of a BEAM-359. It allows to create a coder for generics in a case if the schema for the concrete type parameter is provided. The created coder will be treated as non-deterministic.
For more information look at:
https://issues.apache.org/jira/browse/BEAM-359
apache/beam@9c8dc4f
http://stackoverflow.com/questions/41381648/serializing-generic-class-with-provided-schema-using-avrocoder