-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename module mod_pywebsocket to pywebsocket3 #33
Conversation
Sorry for the delayed response. I want to figure out why the tests are failing and hopefully fix them before landing this. |
@ricea would you need some help in figuring that out? |
@ricea I've added a new commit which fixes the problem. Reason here is that the |
Thanks! Greatly appreciated! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very very nice. lgtm. Before I land it, do you have any ideas how to make the transition easier for downstream users? I guess they can just do s/mod_pywebsocket/pywebsocket3/
so it shouldn't be a huge burden.
Did you ever thought about using GitHub actions to run the tests? It would be much safer to rely on the CI results when code is getting updated. But it may not block the release? |
In the past we used Travis CI but that's not permitted for Google orgs any more. |
To release the package on PyPI (#30) the module has to be renamed to
pywebsocket3
.@ricea can you please have a look? Please note that not all tests are passing right now but that also happens on master, so it's not a regression from this PR.
Failures: