Incorrect path being made in .cmd wrapper on windows.

[rwaldron]

Following the execution path:

jsvu/shared/installer.js

Line 46 in 853836d

this.targetRelPath = `engines/${engine}`;

jsvu/shared/installer.js

Lines 131 to 132 in 853836d

	const wrapperPath = process.platform === 'win32' ?
	`%~dp0${this.targetRelPath}` :

jsvu/shared/installer.js

Line 134 in 853836d

const contents = generateScript(wrapperPath)

Which results in this:

@echo off
"%~dp0engines/v8\v8.exe" --natives_blob="%~dp0engines/v8\natives_blob.bin" --snapshot_blob="%~dp0engines/v8\snapshot_blob.bin" %*

[mathiasbynens]

What's the expected result? What's broken exactly?

[rwaldron]

Aren't these invalid windows paths?

• engines/v8\v8.exe
• engines/v8\natives_blob.bin
• engines/v8\snapshot_blob.bin

This portion: engines/v8, which gets made in this.targetRelPath = `engines/${engine}`; is never passed through a path.normalize().

[mathiasbynens]

cmd.exe accepts both \ and /. We could change the remaining / into \ on Windows but it would be an unobservable change 🤷🏼‍♂️

[mathiasbynens]

To be clear, I'd definitely accept a patch that uses path.join instead of hardcoding the / in shared/installer.js. It's just not a priority IMHO since it doesn't change behavior.

[Nitesh-thapliyal]

Hi @mathiasbynens , I have raised Pull_Request for the same, please review the code and do let me know if any changes required