feat(workbox-precaching) Support for concurrent prefetching #3205
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
C-Hess
commented
May 5, 2023
| @@ -27,10 +28,11 @@ import './_version.js'; | |||
| */ | |||
| function precacheAndRoute( | |||
| entries: Array<PrecacheEntry | string>, | |||
| options?: PrecacheRouteOptions, | |||
| routeOptions?: PrecacheRouteOptions, | |||
| controllerOptions?: PrecacheControllerOptions, | |||
There was a problem hiding this comment.
Not a big fan of the two option arguments. Combining them into a single options argument in a non-breaking manner didn't sit well with me either.
Fix lint Add tests for concurrent precaching Improve documentation
C-Hess
force-pushed
the
feature/concurrent-precache
branch
from
80eabca to
b9d275a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2880
Added the ability to precache requests concurrently. It looks like this used to be a feature in #2528, but was removed because it had no limits to the number of concurrent connections, resulting in a lack of resources for large sites with hundreds of assets.
This feature is opt-in, and should be non-breaking. Though it looks like this ticket is part of the V7 milestone. It may be possible to just bump a minor version for this.
Let me know if there's anything I missed that you'd like to see. One thing that might be interesting in the future is a dynamic concurrent request feature, where the lack of HTTP/2+ support or browser resource errors results in the throttling of the batch sizes.