-
Notifications
You must be signed in to change notification settings - Fork 1.6k
Conversation
Alex Recommends ReportAlex recommends the following language changes, but Alex is a regular expression based algorithm, so take them with a grain of salt. README.md
|
Deploy preview for web-dev-staging ready! Built with commit 17f6168 |
Percy failure can be ignored. It's flaking on an image (related to #3804). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left some comments. Also - maybe consider adding a test for it?
Wouldn't it be enough to restrict the number of items in every collection when the environment is "dev"? |
Maybe, though I think that would require editing the code for all of our collections to use a common filter and we'd need to ensure we use it for new collections as well. It's not a bad idea though and may be safer than physically moving the files (though that seemed to work surprisingly well). I'd also need a way to specify to the filter that it should allow certain posts to remain in the collection(s) (basically whichever post or directory of posts I'm working on). |
I agree it might not be easy, and you probably don't want to remove items from a navigation collection, for example… 😅 |
This adds a (very experimental) feature to improve the quality of life for folks who are developing or authoring content on web.dev.
npm run isolate
can be used to move all files out ofsrc/site/content
and into an_exile
directory which will be ignored for builds.isolate
takes an optional glob (or space separated list of globs) of files that should be preserved.npm run integrate
will restore all of the files in_exile
to their previous location. It will also delete the_exile
directory.Example usage:
(Do some work on style-focus/index.md)
# Restore everything from _exile back to src/site/content npm run integrate
Benchmark
Without isolate:
With isolate:
Changes
Changes proposed in this pull request:
isolate
andintegrate
npm scripts_exile
directory is active