misc(treemap): esc to zoom out #12498
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
patrickhulce
approved these changes
May 18, 2021
| if (!(e instanceof KeyboardEvent)) return; | ||
|
|
||
| if (e.key === 'Enter') this.updateColors(); | ||
|
|
||
| if (e.key === 'Escape' && this.treemap) { | ||
| this.treemap.zoom([]); // zoom out to root |
There was a problem hiding this comment.
is there potential for this have the same recoloring problem (#12496 (comment))? do we need to flip the order to ensure these are recolored? From what I could tell poking around devtools it seemed like the other nodes were just hidden and still there, so not an issue, but calling it out in case it was just oversight.
There was a problem hiding this comment.
played around with it. zoomed into a node, changed view mode with keyboard, zoomed out with ESC. things were colored correctly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
as suggested by brendan
(keypress doesn't catch Escape, but keyup does.)
ref #11254