Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove empty strings from LHR #6281

Closed
exterkamp opened this issue Oct 15, 2018 · 1 comment
Closed

Remove empty strings from LHR #6281

exterkamp opened this issue Oct 15, 2018 · 1 comment

Comments

@exterkamp
Copy link
Member

What is the current behavior?

We should remove empty strings from the LHR to make it strongly consistent with proto + not waste space. e.g.

{
    "displayValue": "",
}

becomes
{}

@exterkamp
Copy link
Member Author

This seemingly isn't too much of an issue. Mostly just a case of the roundtrip testing comparing correctly. We can modify the test to include empty string values in the round trip json, which will make the tests pass all the same but the round trip will be longer. But is totally arbitrary. Personally I think we can just ignore this. @paulirish? @brendankenny? @patrickhulce? Thoughts?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants