Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

scoreDisplayMode incompatable with proto enum: not-applicable #6201

Closed
exterkamp opened this issue Oct 9, 2018 · 4 comments · Fixed by #6783
Closed

scoreDisplayMode incompatable with proto enum: not-applicable #6201

exterkamp opened this issue Oct 9, 2018 · 4 comments · Fixed by #6783
Assignees
@exterkamp
Labels
needs-priority

Comments

@exterkamp
Copy link
Member

What is the current behavior?

An audit's scoreDisplayMode can be not-applicable which is fine in json, but invalid for a proto enum name because of the hyphen.
@exterkamp exterkamp self-assigned this Oct 9, 2018
@exterkamp exterkamp mentioned this issue Oct 9, 2018
Merged
10 tasks
@exterkamp
Copy link
Member Author

Fixing on branch.

@paulirish paulirish mentioned this issue Oct 15, 2018
Closed
10 tasks
@paulirish paulirish changed the title scoreDisplayMode incompatable with proto enum scoreDisplayMode incompatable with proto enum: not-applicable Oct 23, 2018
@paulirish paulirish mentioned this issue Oct 23, 2018
Closed
@brendankenny brendankenny mentioned this issue Nov 13, 2018
Merged
@exterkamp
Copy link
Member Author

@brendankenny brought up a good point to sidestep this issue. We can rename not-applicable to something that can be consistent in both proto and LHR e.g.

  • notapplicable
  • notApplicable
  • auditplicable

something like that. Thoughts?

@patrickhulce
Copy link
Collaborator

patrickhulce commented Dec 10, 2018 •
edited by paulirish
Loading

auditplicable

😆 we obviously gotta go with this one now, right?

I like notApplicable, personally.

@paulirish
Copy link
Member

notApplicable wfm

This was referenced Dec 12, 2018
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@exterkamp exterkamp

Labels
needs-priority
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

core: change 'not-applicable' to 'notApplicable' GoogleChrome/lighthouse
3 participants
@paulirish @patrickhulce @exterkamp