Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove usage of /deep/ #1913

Closed
ebidel opened this issue Mar 27, 2017 · 2 comments
Closed

Remove usage of /deep/ #1913

ebidel opened this issue Mar 27, 2017 · 2 comments
Assignees
Labels

Comments

@ebidel
Copy link
Contributor

ebidel commented Mar 27, 2017

Intent to deprecate has gone out. Eventually /deep/ will be aliased to "". This means our usage of /deep/ in gathers (document.querySelecotorAll('html /deep/ *')) will become document.querySelecotorAll('html *') and we'll miss out on nodes within shadow trees.

We'll need to switch over to DOM traversal.

email that went to blink-dev: https://groups.google.com/a/chromium.org/forum/#!msg/blink-dev/68qSZM5QMRQ/pT2YCqZSomAJ

@ebidel ebidel self-assigned this Apr 7, 2017
@ebidel
Copy link
Contributor Author

ebidel commented May 22, 2017

/deep/ is being removed in Chrome 60. I'll get going on this.

https://www.chromestatus.com/feature/4964279606312960

@ebidel
Copy link
Contributor Author

ebidel commented May 24, 2017

Filed an upstream FR ^ (ChromeDevTools/devtools-protocol#19) to add better support for this int he DT protocol. We can get all nodes with the substrees fairly easily, but making DOM.querySelector[All] shadow dom aware would be more flexible, long-term.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants