Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: forwards support for fs.rm in node 14.14+ #242

Merged
merged 1 commit into from
Nov 1, 2021

Conversation

lukebro
Copy link
Contributor

@lukebro lukebro commented Jun 14, 2021

In node v14.14+ a deprecation warning is now always given:

[DEP0147] DeprecationWarning: In future versions of Node.js, fs.rmdir(path, { recursive: true }) will be removed. Use fs.rm(path, { recursive: true }) instead
(Use node --trace-deprecation ... to show where the warning was created)
nodejs.org/api/deprecations.html#DEP0147

So I've checked for the existence of fs.rm in favor of fs.rmdir if available, which should support v16+ but also v12.

@google-cla
Copy link

google-cla bot commented Jun 14, 2021

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@lukebro
Copy link
Contributor Author

lukebro commented Jun 14, 2021

@googlebot I signed it!

@paulshryock
Copy link

Let's do this.

Copy link
Member

@brendankenny brendankenny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the delay, LGTM. Would love to have this in for the next Lighthouse release.

@brendankenny brendankenny merged commit 56731dd into GoogleChrome:master Nov 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants