Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move download-chrome.sh to chrome-launcher and make easily callable #5

Closed
devtools-bot opened this issue Aug 29, 2017 · 5 comments
Closed

Comments

@devtools-bot
Copy link
Collaborator

From @patrickhulce on June 15, 2017 22:16

At one point we published the download-chrome.sh script with lighthouse that was handy for downstreamers to use when running in CI. It might be a nice feature of chrome-launcher to provide a similar mechanism to download/install chrome cross platform as well.

Copied from original issue: GoogleChrome/lighthouse#2510

@devtools-bot
Copy link
Collaborator Author

From @busticated on June 20, 2017 19:7

fwiw, it would be awesome to have something like https://github.com/Medium/phantomjs

using this, i simply add the phantomjs-prebuilt dependency to my package.json, npm i (w/ caching) in my CI env, and run tests. works great. would love to drop in a chrome-powered replacement.

@devtools-bot
Copy link
Collaborator Author

From @paulirish on June 20, 2017 20:22

@busticated yeah true. we have no short term plans to make a production-ready chrome-stable-prebuilt npm package but we definitely see the value in it.

If someone wants to start working on this, we'd be happy to see that!

@paulirish
Copy link
Member

partially fixed in #18

script is here: https://github.com/GoogleChrome/chrome-launcher/blob/master/scripts/download-chrome.sh

but it's not cross-platform..

also https://github.com/GoogleChrome/puppeteer/blob/master/utils/ChromiumDownloader.js is nice, but it's Chromium rather than chrome.

@samccone
Copy link
Contributor

samccone commented Dec 9, 2017

imho this is out of scope for this tool. Instead if we wanted to build a x-platform chrome-installer package that seems like a good move.

Thanks for filing this request!

@samccone samccone closed this as completed Dec 9, 2017
@paulirish
Copy link
Member

Sgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants