-
Notifications
You must be signed in to change notification settings - Fork 191
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move download-chrome.sh to chrome-launcher and make easily callable #5
Comments
From @busticated on June 20, 2017 19:7 fwiw, it would be awesome to have something like https://github.com/Medium/phantomjs using this, i simply add the |
From @paulirish on June 20, 2017 20:22 @busticated yeah true. we have no short term plans to make a production-ready If someone wants to start working on this, we'd be happy to see that! |
partially fixed in #18 script is here: https://github.com/GoogleChrome/chrome-launcher/blob/master/scripts/download-chrome.sh but it's not cross-platform.. also https://github.com/GoogleChrome/puppeteer/blob/master/utils/ChromiumDownloader.js is nice, but it's Chromium rather than chrome. |
imho this is out of scope for this tool. Instead if we wanted to build a x-platform chrome-installer package that seems like a good move. Thanks for filing this request! |
Sgtm |
From @patrickhulce on June 15, 2017 22:16
At one point we published the
download-chrome.sh
script with lighthouse that was handy for downstreamers to use when running in CI. It might be a nice feature of chrome-launcher to provide a similar mechanism to download/install chrome cross platform as well.Copied from original issue: GoogleChrome/lighthouse#2510
The text was updated successfully, but these errors were encountered: