Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

upgrade semver validation to disallow leading zeros and overly long versions #71

Merged
merged 3 commits into from
Jan 21, 2023
Merged

upgrade semver validation to disallow leading zeros and overly long versions #71

merged 3 commits into from
Jan 21, 2023

Conversation

Qubus0
Copy link
Collaborator

@Qubus0 Qubus0 commented Jan 21, 2023

No description provided.

@Qubus0 Qubus0 requested a review from a team January 21, 2023 10:57
@Qubus0 Qubus0 changed the base branch from main to develop January 21, 2023 11:05
KANAjetzt
KANAjetzt approved these changes Jan 21, 2023
View reviewed changes
Copy link
Member

@KANAjetzt KANAjetzt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅

@Qubus0 Qubus0 merged commit e36724b into GodotModding:develop Jan 21, 2023
@Qubus0 Qubus0 deleted the no_leading_zero_semver branch January 21, 2023 13:59
@KANAjetzt KANAjetzt mentioned this pull request Feb 15, 2023
Merged
This was referenced Feb 23, 2023
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KANAjetzt KANAjetzt KANAjetzt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Qubus0 @KANAjetzt