Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v5.0.1 #123

Merged
merged 91 commits into from
Feb 23, 2023
Merged

v5.0.1 #123

merged 91 commits into from
Feb 23, 2023

Conversation

KANAjetzt
Copy link
Member

@KANAjetzt KANAjetzt commented Feb 23, 2023

by @ithinkandicode:_

Includes PR #69, and all merged PRs from #70 up to PR #110

Qubus0 and others added 30 commits January 20, 2023 21:37
fix mods dir path not being overridden
fix type inference of game_mod_folder_path
ithinkandicode and others added 20 commits February 8, 2023 10:09
…elog

`log_fatal` - add the missing log to file
* fix: properly parse all types of command line arg values

* refactor: adjust code line in doc comments

* refactor: add cmdline arg fixing wrapper function

* fix: also cover args without =
because the notice is most likely to be seen by modders in the editor, who won't be using the `mods` dir
* `get_mod_config` - fix missing space in log string

* `get_mod_config` - log improvements

- Generally improve log messages, giving them better user notices that are more accurate to the current issue.
- Use assert for cases where there are definite code errors that need addressing (eg. an invalid mod ID)

* `get_mod_config` - use enums for the error codes

* `get_mod_config` - rename "error" (eg. "error code") to "status"

* `get_mod_config` - remove a redundant bit of text
* ✔ added checks for override.cfg setup

* 🧹 removed logging when no autoloads are set up

If there is no autoloads there will be no mod_loader.gd
* `add_translation_from_resource` - Validate file exists

* `add_translation_from_resource` - fix log name in previous commit
@KANAjetzt KANAjetzt added this to the v5.0.0 milestone Feb 23, 2023
@KANAjetzt KANAjetzt requested review from ithinkandicode, Qubus0 and a team February 23, 2023 16:44
Copy link
Collaborator

@Qubus0 Qubus0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no more squashing 👍

@KANAjetzt KANAjetzt merged commit b372e77 into main Feb 23, 2023
@KANAjetzt KANAjetzt deleted the __develop branch February 23, 2023 16:59
Copy link
Collaborator

@ithinkandicode ithinkandicode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants