Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

validate mod ids completely #54

Closed
Qubus0 opened this issue Jan 16, 2023 · 0 comments · Fixed by #60
Closed

validate mod ids completely #54

Qubus0 opened this issue Jan 16, 2023 · 0 comments · Fixed by #60
Assignees
Labels
validation Feature to make things safe and predictable

Comments

@Qubus0
Copy link
Collaborator

Qubus0 commented Jan 16, 2023

as per the info by thunderstore, a "full id" would be {namespace}-{name}-{version_number}
I'm not sure what we would call this id, maybe something like "full_name_id"?

the validation does address the composition, but not the elements of that composition. following thunderstore,
namespace and name are are validated with this ^[a-zA-Z0-9_]$ (where _ can only be replaced with space for display purposes)
and the version_number with this ^[0-9]+\.[0-9]+\.[0-9]+$
Godot does have a regex class you can use

Originally posted by @Qubus0 in #51 (review)

@Qubus0 Qubus0 self-assigned this Jan 19, 2023
@ithinkandicode ithinkandicode added the validation Feature to make things safe and predictable label Mar 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
validation Feature to make things safe and predictable
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants