Force Chocolatey to use the proxy settings #74
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
obilodeau
suggested changes
Sep 6, 2017
Contributor
obilodeau
left a comment
obilodeau
left a comment
There was a problem hiding this comment.
Looks good. Only a minor indentation issue.
| "inline": [ | ||
| {% if proxy %} | ||
| {# Sometimes, choco decide to ignore the proxy... #} | ||
| "choco config set proxy {{ proxy }}", |
Contributor
There was a problem hiding this comment.
Can you please indent the lines under the if?
| "inline": [ | ||
| {% if proxy %} | ||
| {# Sometimes, choco decide to ignore the proxy... #} | ||
| "choco config set proxy {{ proxy }}", |
Contributor
There was a problem hiding this comment.
Can you please indent the lines under the if?
Sometimes, chocolatey decides to ignore the proxy settings, The best way is to force it is through `choco config` $ choco config set proxy proxy_address:3128 Signed-off-by: Camille Moncelier <camille@moncelier.fr>
Contributor
Author
|
Is it ok now ? |
obilodeau
approved these changes
Sep 6, 2017
Contributor
|
Thanks! |
obilodeau
added a commit
that referenced
this pull request
Sep 6, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sometimes, chocolatey decides to ignore the proxy settings,
The best way is to force it is through
choco config$ choco config set proxy proxy_address:3128