Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support for VIDIOC_S_CTRL? #12

Open
mfreeborn opened this issue Jan 22, 2023 · 2 comments
Open

Support for VIDIOC_S_CTRL? #12

mfreeborn opened this issue Jan 22, 2023 · 2 comments

Comments

@mfreeborn
Copy link

I'm trying to implement an H264 encoder in Rust, which takes YUV420 format frames from a Raspberry Pi camera and converts it to H264. Essentially I'm trying to replicate this functionality: https://github.com/raspberrypi/libcamera-apps/blob/eca5a3c5eada4b3caa52a7ed33eafd4eb0be78c7/encoder/h264_encoder.cpp#L41

Have I interpreted the v4l2r::ioctl module correctly in that it doesn't support VIDIOC_S_CTRL to do things such as set the H264 profile and level etc?

I otherwise have a working pipeline based on the v4l2r::encoder::Encoder which is really great.
@mfreeborn mfreeborn mentioned this issue Jan 22, 2023
Closed
@Gnurou
Copy link
Owner

Gnurou commented Jan 23, 2023

Hi! Right, support for controls is missing at the moment. I'll try to review your PR shortly.

@Gnurou
Copy link
Owner

Gnurou commented Oct 31, 2023

Now that support for VIDIOC_S_EXT_CTRLS is merged, can we close this issue?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add support for ioctl VIDIOC_S_CTRL
2 participants
@Gnurou @mfreeborn