Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement(admin-ui): Explore the possibility of using redux-toolkit to improve the redux code #81

Closed
syntrydy opened this issue Feb 17, 2022 · 3 comments
Assignees
Labels
comp-admin-ui Component affected by issue or PR kind-bug Issue or PR is a bug in existing functionality

Comments

@syntrydy
Copy link
Contributor

Please check the doc here https://redux-toolkit.js.org/introduction/getting-started

@syntrydy syntrydy added the bug Something isn't working label Feb 17, 2022
@duttarnab duttarnab added the comp-admin-ui Component affected by issue or PR label Feb 17, 2022
@ossdhaval ossdhaval added kind-bug Issue or PR is a bug in existing functionality and removed bug Something isn't working labels Feb 22, 2022
@mjatin-dev
Copy link
Contributor

Hi @syntrydy , to convert our application to the redux toolkit standards, we need to start from the store, as per toolkit standards store will be defined as configureStore instead of createStore moreover we need to change all the action methods to the slice which is toolkit standard and need to link all the saga actions to the slice itself.

Overall I can say we need to define almost all the things used in redux again to the toolkit standards.

@jv18creator
Copy link
Contributor

We can define action methods in slice & keep the saga logic as it is. That way we won't have to create everything from scratch. The only thing will change in this case will be way of writing reducer. Instead of defining into seperate file, we could define it in slice. @duttarnab please review 483774d

@duttarnab
Copy link
Contributor

Done for scope, session. We will raise issue for rest of code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
comp-admin-ui Component affected by issue or PR kind-bug Issue or PR is a bug in existing functionality
Projects
None yet
Development

No branches or pull requests

5 participants