From 55e09d6bf8426a70b27ca46f405c3377f79c8b1d Mon Sep 17 00:00:00 2001
From: isidor <inikolic@microsoft.com>
Date: Tue, 28 Jul 2020 19:15:56 +0200
Subject: [PATCH] update extensions aria label to contain version and publisher
 display name

fixes #102224
---
 .../workbench/contrib/extensions/browser/extensionsViewer.ts  | 3 ++-
 .../workbench/contrib/extensions/browser/extensionsViews.ts   | 2 +-
 test/automation/src/extensions.ts                             | 4 ++--
 3 files changed, 5 insertions(+), 4 deletions(-)

diff --git a/src/vs/workbench/contrib/extensions/browser/extensionsViewer.ts b/src/vs/workbench/contrib/extensions/browser/extensionsViewer.ts
index 89ac951350f99..5ee60dcc4096f 100644
--- a/src/vs/workbench/contrib/extensions/browser/extensionsViewer.ts
+++ b/src/vs/workbench/contrib/extensions/browser/extensionsViewer.ts
@@ -271,7 +271,8 @@ export class ExtensionsTree extends WorkbenchAsyncDataTree<IExtensionData, IExte
 				overrideStyles,
 				accessibilityProvider: <IListAccessibilityProvider<IExtensionData>>{
 					getAriaLabel(extensionData: IExtensionData): string {
-						return localize('extension-arialabel', "{0}. Press enter for extension details.", extensionData.extension.displayName);
+						const extension = extensionData.extension;
+						return localize('extension-arialabel', "{0}, {1}, {2}, press enter for extension details.", extension.displayName, extension.version, extension.publisherDisplayName);
 					},
 					getWidgetAriaLabel(): string {
 						return localize('extensions', "Extensions");
diff --git a/src/vs/workbench/contrib/extensions/browser/extensionsViews.ts b/src/vs/workbench/contrib/extensions/browser/extensionsViews.ts
index 9e9a43d2fbb1e..2fdba645427b7 100644
--- a/src/vs/workbench/contrib/extensions/browser/extensionsViews.ts
+++ b/src/vs/workbench/contrib/extensions/browser/extensionsViews.ts
@@ -139,7 +139,7 @@ export class ExtensionsListView extends ViewPane {
 			horizontalScrolling: false,
 			accessibilityProvider: <IListAccessibilityProvider<IExtension | null>>{
 				getAriaLabel(extension: IExtension | null): string {
-					return extension ? localize('extension-arialabel', "{0}. Press enter for extension details.", extension.displayName) : '';
+					return extension ? localize('extension-arialabel', "{0}, {1}, {2}, press enter for extension details.", extension.displayName, extension.version, extension.publisherDisplayName) : '';
 				},
 				getWidgetAriaLabel(): string {
 					return localize('extensions', "Extensions");
diff --git a/test/automation/src/extensions.ts b/test/automation/src/extensions.ts
index 01d8efd61ef81..f7bf11891b907 100644
--- a/test/automation/src/extensions.ts
+++ b/test/automation/src/extensions.ts
@@ -34,9 +34,9 @@ export class Extensions extends Viewlet {
 		await this.code.waitForTypeInEditor(SEARCH_BOX, `@id:${id}`);
 	}
 
-	async installExtension(id: string, name: string): Promise<void> {
+	async installExtension(id: string, name: string, version: string, publisherDisplayName: string): Promise<void> {
 		await this.searchForExtension(id);
-		const ariaLabel = `${name}. Press enter for extension details.`;
+		const ariaLabel = `${name}, ${version}, ${publisherDisplayName}, press enter for extension details.`;
 		await this.code.waitAndClick(`div.extensions-viewlet[id="workbench.view.extensions"] .monaco-list-row[aria-label="${ariaLabel}"] .extension-list-item li[class='action-item'] .extension-action.install`);
 		await this.code.waitForElement(`.extension-editor .monaco-action-bar .action-item:not(.disabled) .extension-action.uninstall`);
 	}