Use scope instead of grammar name

[timkelty]

Using editor.getGrammar().name requires there to be a specific beautifier for the current grammar. This is unfortunate because of how scope extension and nesting works.

Consider a templating language, e.g. "Smarty". Ideally I should be able to beautify as HTML in this grammar, as the scopeName is text.html.smarty. However, since you're only using the grammar name, I have to switch grammars to be able to beautify.

Related/Similar issue: emmetio/emmet-atom#376

[timkelty]

More reference: https://discuss.atom.io/t/why-do-so-many-packages-ignore-scope-and-only-use-grammar-name/24724

[Glavin001]

This is a very interesting idea.

Applicable code sections for someone who may want to try implementing this:

• https://github.com/Glavin001/atom-beautify/blob/master/src/beautifiers/index.coffee#L390-L395
• https://github.com/Glavin001/atom-beautify/blob/master/src/beautifiers/index.coffee#L314-L326
• https://github.com/Glavin001/atom-beautify/blob/master/src/languages/index.coffee#L84-L91

[timkelty]

Thanks!

[timkelty]

It seems that perhaps editor.scopeDescriptorForBufferPosition().getScopesArray() is the right method here to use, actually: emmetio/emmet-atom#376 (comment)

[Glavin001]

I'd love to see a Pull Request implementing something in this direction! Major changes are happening for #1174 and if this is the right direction then I would want this improvement to be in the next major release! Thanks in advance.

[stale]

This issue has been automatically marked as stale because it has not had recent activity. If this is still an issue, please add a comment. It will be closed if no further activity occurs. Thank you for your contributions.