Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Think about combining repositories into cargo workspace #9

Open
lbirkert opened this issue Sep 17, 2023 · 2 comments
Open

Think about combining repositories into cargo workspace #9

lbirkert opened this issue Sep 17, 2023 · 2 comments

Comments

@lbirkert
Copy link

This would allow us to fix & test bugs more quickly, who are introduced by a local dependency of the rustpotter family, as we are not depending on crates.io (which requires a new version to be published before such an issue can be fixed).

@GiviMAD
Copy link
Owner

GiviMAD commented Sep 17, 2023

Right now I'm relying on changing the cargo dependency while developing.

But yes it will probably make things easier, I think that keeping the library in a separate repo and having another one with all the other tools and the library as a submodule is the option I like more. I think I can place that repo at https://github.com/rustpotter.

I will try to look at it when I have a moment.

I'll like also to investigate if libraries for other languages can be develop in an "easy" way, there are some tools I would like to investigate like wasmtime, but I haven't found the time to look a it. But having all in a repo which people can PR to seems a good idea in case someone wants to work on supporting a new language.

@GiviMAD
Copy link
Owner

GiviMAD commented Oct 1, 2023

At the end I'm not so convinced to change it to a workspace.

I think it can be too much code from different languages in the same repo, and I see some advantages on it but I also with the flexibility offered by cargo for installing from local folders or git repositories I don't see it like something needed.

I'm still thinking on it, but with the amount of work I have at the moment don't think I can do it for now either way.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants