Install liblzma-dev in CI test job
#1623
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Oct 13, 2024
Per actions/runner-images#10636, the `ubuntu-latest` GitHub Actions hosted runner label is being migrated from aliasing `ubuntu-22.04` to aliasing `ubuntu-24.04`. Our `ci.yml` workflow, which includes the full `test` job, uses `ubuntu-latest`, and recently has switched automatically to using an Ubuntu 24.04 runner. It makes sense to use this newer version, but that runner apparently does not preinstall the headers required to build with `-llzma`. That causes `just ci-test` to fail at `cargo nextest run -p gix-testtools --features xz` with `/usr/bin/ld: cannot find -llzma: No such file or directory`. This commit installs the `liblzma-dev` package that provides the required headers, so we can use Ubuntu 24.04 LTS while continuing to test the `xz` feature of `gix-testtools`. The failure this addresses was first observed in GitoxideLabs#1618 at 64e0f78: https://github.com/GitoxideLabs/gitoxide/actions/runs/11304216949/job/31442302018?pr=1618 But it is not caused by any of the changes there, and it now occurs whenever the `test` job is run, including if it is re-run at the tip of the main branch (or any other branch), such as in: https://github.com/EliahKagan/gitoxide/actions/runs/11317510844/job/31471040361 In both cases, expanding *Set up job* > *Operating system* shows Ubuntu 24.04.1 LTS. (The failure this addresses is also not related to GitoxideLabs#1622, which documents an unrelated failure that is possible to observe locally and that, if no change is made related to it, can be expected to occur on CI in the `test` starting sometime soon, but that is not yet seen on CI.)
EliahKagan
force-pushed
the
run-ci/fix-test-xz
branch
from
a5d01f1
to
f9ecb47
Compare
|
Thanks a million, much appreciated! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per actions/runner-images#10636, the
ubuntu-latestGitHub Actions hosted runner is being migrated fromubuntu-22.04toubuntu-24.04. Theci.ymlworkflow, including the fulltestjob, usesubuntu-latest, and recently has switched over to using the Ubuntu 24.04 runner.It makes sense to use this newer version, but that runner apparently does not preinstall the headers required to build with
-llzma. That causesjust ci-testto fail at:The error message is:
This PR installs the
liblzma-devpackage that provides the required headers, so we can use Ubuntu 24.04 LTS while continuing to test thexzfeature ofgix-testtools.The failure this addresses was first observed in #1618 at 64e0f78: https://github.com/GitoxideLabs/gitoxide/actions/runs/11304216949/job/31442302018?pr=1618
But it is not caused by any of the changes there, and it now occurs whenever the
testjob is run, including if it is re-run at the tip of the main branch (or any other branch), such as in: https://github.com/EliahKagan/gitoxide/actions/runs/11317510844/job/31471040361In both cases, expanding Set up job > Operating system shows Ubuntu 24.04.1 LTS.
(The failure this addresses is also not related to #1622, which documents an unrelated failure that is possible to observe locally and that, if no change is made related to it, can be expected to occur on CI in the
testjob starting sometime soon, but that is not yet seen on CI.)