fix!: use dyn trait where possible.

This reduces compile time due to avoiding duplication.

Author: Byron

gix-actor/src/identity.rs

@@ -35,14 +35,14 @@ mod write {
     /// Output
     impl Identity {
         /// Serialize this instance to `out` in the git serialization format for signatures (but without timestamp).
-        pub fn write_to(&self, out: impl std::io::Write) -> std::io::Result<()> {
+        pub fn write_to(&self, out: &mut dyn std::io::Write) -> std::io::Result<()> {
             self.to_ref().write_to(out)
         }
     }
 
     impl<'a> IdentityRef<'a> {
         /// Serialize this instance to `out` in the git serialization format for signatures (but without timestamp).
-        pub fn write_to(&self, mut out: impl std::io::Write) -> std::io::Result<()> {
+        pub fn write_to(&self, out: &mut dyn std::io::Write) -> std::io::Result<()> {
             out.write_all(validated_token(self.name)?)?;
             out.write_all(b" ")?;
             out.write_all(b"<")?;

gix-actor/src/signature/mod.rs

@@ -95,7 +95,7 @@ pub(crate) mod write {
     /// Output
     impl Signature {
         /// Serialize this instance to `out` in the git serialization format for actors.
-        pub fn write_to(&self, out: impl std::io::Write) -> std::io::Result<()> {
+        pub fn write_to(&self, out: &mut dyn std::io::Write) -> std::io::Result<()> {
             self.to_ref().write_to(out)
         }
         /// Computes the number of bytes necessary to serialize this signature
@@ -106,7 +106,7 @@ pub(crate) mod write {
 
     impl<'a> SignatureRef<'a> {
         /// Serialize this instance to `out` in the git serialization format for actors.
-        pub fn write_to(&self, mut out: impl std::io::Write) -> std::io::Result<()> {
+        pub fn write_to(&self, out: &mut dyn std::io::Write) -> std::io::Result<()> {
             out.write_all(validated_token(self.name)?)?;
             out.write_all(b" ")?;
             out.write_all(b"<")?;

gix-actor/tests/signature/mod.rs

@@ -11,7 +11,7 @@ mod write_to {
                 time: default_time(),
             };
             assert_eq!(
-                format!("{:?}", signature.write_to(Vec::new())),
+                format!("{:?}", signature.write_to(&mut Vec::new())),
                 "Err(Custom { kind: Other, error: IllegalCharacter })"
             );
         }
@@ -24,7 +24,7 @@ mod write_to {
                 time: default_time(),
             };
             assert_eq!(
-                format!("{:?}", signature.write_to(Vec::new())),
+                format!("{:?}", signature.write_to(&mut Vec::new())),
                 "Err(Custom { kind: Other, error: IllegalCharacter })"
             );
         }
@@ -37,7 +37,7 @@ mod write_to {
                 time: default_time(),
             };
             assert_eq!(
-                format!("{:?}", signature.write_to(Vec::new())),
+                format!("{:?}", signature.write_to(&mut Vec::new())),
                 "Err(Custom { kind: Other, error: IllegalCharacter })"
             );
         }