Skip to content

Fix E2E icons #3222

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 8, 2025
Merged

Fix E2E icons #3222

merged 1 commit into from
May 8, 2025

Conversation

gregberge
Copy link
Contributor

@gregberge gregberge commented May 8, 2025 •
edited
Loading

I use a new strategy, removing the URL and use a inline data URL instead, it should fix the remaining issue we have in E2E icons loading.

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented May 8, 2025

⚠️ No Changeset found

Latest commit: a16127d

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented May 8, 2025

Summary of the deployments:

Version 1

Version URL Status
Latest commit https://bbd1a100.gitbook-open.pages.dev ✅
PR https://pr3222.gitbook-open.pages.dev ✅

Version 2

Version URL Status
Vercel https://gitbook-v2-locbi3dwh-gitbook.vercel.app ✅
Cloudflare https://377123e0-gitbook-open-v2-preview.gitbook.workers.dev ✅

Test content

Site v1 2v 2c
GitBook https://bbd1a100.gitbook-open.pages.dev/docs.gitbook.com https://gitbook-v2-locbi3dwh-gitbook.vercel.app/url/docs.gitbook.com https://377123e0-gitbook-open-v2-preview.gitbook.workers.dev/url/docs.gitbook.com
E2E https://bbd1a100.gitbook-open.pages.dev/gitbook.gitbook.io/test-gitbook-open https://gitbook-v2-locbi3dwh-gitbook.vercel.app/url/gitbook.gitbook.io/test-gitbook-open https://377123e0-gitbook-open-v2-preview.gitbook.workers.dev/url/gitbook.gitbook.io/test-gitbook-open

@argos-ci Argos CI
Copy link

argos-ci bot commented May 8, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Argos notifications ↗︎

Build Status Details Updated (UTC)
customers-v1 (Inspect) ✅ No changes detected - May 8, 2025, 6:59 AM
customers-v2 (Inspect) 👍 Changes approved 83 changed May 8, 2025, 7:04 AM
default (Inspect) 👍 Changes approved 7 changed May 8, 2025, 7:02 AM
v2-vercel (Inspect) 👍 Changes approved 6 changed May 8, 2025, 7:06 AM

@gregberge gregberge enabled auto-merge (squash) May 8, 2025 07:06
@gregberge gregberge requested review from SamyPesse and nolannbiron May 8, 2025 07:06
@gregberge gregberge merged commit 47f01ed into main May 8, 2025
20 checks passed
@gregberge gregberge deleted the e2e-icon-strategy branch May 8, 2025 07:34
clairechabas added a commit that referenced this pull request May 9, 2025
@clairechabas
Merge branch 'main' into claire/rnd-6959-add-support-for-tabs-links-i…
50cb393 
…n-gbo

* main:
  Use next@15.3.2 instead of canary (#3227)
  Remove header logo rounding (#3225)
  Always link main logo to the root of the site (#3226)
  Adapt site resolution/lookup to pass visitor unsigned claims in addition to token (#3202)
  Passthrough SVG images in image resizing (#3224)
  Handle invalid OpenAPI Responses (#3223)
  Fix E2E icons (#3222)
  Fix sitemap URLs (#3220)
  Prevent section group popovers from opening on click (#3213)
  Update site redirect regex for validation (#3216)
  Fix code highlighting for HTTP (#3214)
  Fix Python code sample "null vs None" (#3215)
  Fix resolution of links in reusable content (#3212)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@taranvohra taranvohra taranvohra approved these changes

@SamyPesse SamyPesse Awaiting requested review from SamyPesse

@nolannbiron nolannbiron Awaiting requested review from nolannbiron

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gregberge @taranvohra