Skip to content

Page outline positioning #2805

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

zenoachtig
Copy link
Contributor

@zenoachtig zenoachtig commented Feb 4, 2025

Fixes RND-6068, RND-5185, and RND-2805.

Outline stickiness and mode toggle

  • Outline now stays in view as much as possible
  • Mode toggle is displayed in outline sidebar, eliminating the need for a footer if it only contains a mode toggle
  • Mode toggle is now available on pages without an outline view, like landing pages
Screenshot 2025-02-04 at 12 08 55 Screenshot 2025-02-04 at 12 09 26

Ad alignment

  • Ad blocks now always display at the bottom of the view, together with mode toggle (if enabled)
Screenshot 2025-02-04 at 12 11 04 Screenshot 2025-02-04 at 12 11 18
  • Mode toggle (and ad) are always in view, even when the page outline starts underneath the page cover
Screenshot 2025-02-04 at 12 16 14 Screenshot 2025-02-04 at 12 17 34

Footer tweaks

  • Footer has been tweaked to rely less on the left and right columns. In the future we might make the sidebars sticky to prevent scrolling it up altogether.
Screenshot 2025-02-04 at 12 19 54 Screenshot 2025-02-04 at 12 19 49

Copy link

changeset-bot bot commented Feb 4, 2025

🦋 Changeset detected

Latest commit: 7fe28df

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
gitbook Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

github-actions bot commented Feb 4, 2025

Copy link

argos-ci bot commented Feb 4, 2025

The latest updates on your projects. Learn more about Argos notifications ↗︎

Build Status Details Updated (UTC)
default (Inspect) 👍 Changes approved 70 changed, 4 added Feb 5, 2025, 3:03 PM

zenoachtig and others added 3 commits February 5, 2025 12:28
Co-authored-by: Claire Chabas <claire.chabas@gmail.com>
Co-authored-by: Claire Chabas <claire.chabas@gmail.com>
@zenoachtig zenoachtig merged commit e90c96f into main Feb 5, 2025
12 checks passed
@zenoachtig zenoachtig deleted the zeno/rnd-6068-gbo-pages-list-on-the-right-should-remain-visible-when branch February 5, 2025 16:08
Copy link

linear bot commented Feb 6, 2025

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants