Skip to content

Improve styles of Tables #2623

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Dec 13, 2024
Merged

Improve styles of Tables #2623

merged 5 commits into from
Dec 13, 2024

Conversation

viktorrenkema
Copy link
Contributor

This PR changes some of the styling of Tables to make them feel more up to date.

  • we use the tint if provided by the customization settings
  • we inherit the rounded or sharp angles if provided by customization

Screenshots

Examples of sample and existing public docs in light and dark mode

Before

Keeper:
CleanShot 2024-12-11 at 21 56 06@2x

Snyk:
CleanShot 2024-12-11 at 21 57 34@2x

After

Keeper:
CleanShot 2024-12-11 at 21 53 41@2x

Snyk:
CleanShot 2024-12-11 at 21 53 49@2x

Snyk dark:
CleanShot 2024-12-11 at 21 54 15@2x

Local, sharp radius set in customization settings:
CleanShot 2024-12-11 at 21 53 55@2x

@linear Linear
Copy link

linear bot commented Dec 11, 2024

RND-5815 Improve style of Tables

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Dec 11, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: eb07014

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 11, 2024 •
edited
Loading

GitBook Preview
Latest commit: https://5083f3b8.gitbook-open.pages.dev
PR: https://pr2623.gitbook-open.pages.dev

@argos-ci Argos CI
Copy link

argos-ci bot commented Dec 11, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Argos notifications ↗︎

Build Status Details Updated (UTC)
default (Inspect) 👍 Changes approved 15 changed, 36 added Dec 13, 2024, 7:00 AM

zenoachtig
zenoachtig approved these changes Dec 12, 2024
View reviewed changes
Copy link
Contributor

@zenoachtig zenoachtig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, nice job using tint!

scazan
scazan approved these changes Dec 12, 2024
View reviewed changes
Copy link
Contributor

@scazan scazan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code looks good. assuming the styles were tested across mobile and desktop and checked already. :)

valentin0h
valentin0h approved these changes Dec 12, 2024
View reviewed changes
Copy link
Contributor

@valentin0h valentin0h left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice 👌

@valentin0h
Copy link
Contributor

code looks good. assuming the styles were tested across mobile and desktop and checked already. :)

Or better check if there's visual tests for it and if not add one.

viktorrenkema
viktorrenkema commented Dec 12, 2024
View reviewed changes
@viktorrenkema viktorrenkema force-pushed the viktor/rnd-5815/table-styles branch from db263a1 to cf9bb5d Compare December 12, 2024 14:26
@viktorrenkema viktorrenkema force-pushed the viktor/rnd-5815/table-styles branch from b203e93 to a0884c9 Compare December 12, 2024 15:08
@viktorrenkema viktorrenkema force-pushed the viktor/rnd-5815/table-styles branch from a0884c9 to eeeeecc Compare December 13, 2024 06:45
@viktorrenkema viktorrenkema merged commit 6b5d7e6 into main Dec 13, 2024
9 checks passed
@viktorrenkema viktorrenkema deleted the viktor/rnd-5815/table-styles branch December 13, 2024 07:15
clairechabas added a commit that referenced this pull request Dec 13, 2024
@clairechabas
Merge branch 'main' into claire/RND-5709-trigger-search-on-enter
b64a8bb 
* main:
  Improve styles of Tables (#2623)
  Fix expandable block anchor resolution (#2625)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@scazan scazan scazan approved these changes

@valentin0h valentin0h valentin0h approved these changes

@zenoachtig zenoachtig zenoachtig approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@viktorrenkema @valentin0h @scazan @zenoachtig