Fix running GitBook locally and fix community ad rendering (#2437)

Author: SamyPesse

.changeset/weak-hairs-compete.md

@@ -0,0 +1,5 @@
+---
+'gitbook': patch
+---
+
+Fix "ip" being passed to BSA for community ads

.github/workflows/ci.yaml

@@ -158,6 +158,24 @@ jobs:
               env:
                   PUPPETEER_SKIP_DOWNLOAD: 1
             - run: bun unit
+    build-oss:
+        # CI to check that the repository builds correctly on a machine without the credentials
+        runs-on: ubuntu-latest
+        name: Build (Open Source)
+        env:
+            NPMRC_FONT_AWESOME_TOKEN: ''
+        steps:
+            - name: Checkout
+              uses: actions/checkout@v4
+            - name: Setup bun
+              uses: oven-sh/setup-bun@v1
+              with:
+                  bun-version: 1.1.18
+            - name: Install dependencies
+              run: bun install --frozen-lockfile
+              env:
+                  PUPPETEER_SKIP_DOWNLOAD: 1
+            - run: bun run build
     typecheck:
         runs-on: ubuntu-latest
         name: Typecheck

packages/gitbook/package.json

@@ -3,7 +3,7 @@
     "version": "0.3.0",
     "private": true,
     "scripts": {
-        "dev": "env-cmd -f ../../.env.local next dev",
+        "dev": "env-cmd --silent -f ../../.env.local next dev",
         "build": "next build",
         "build:cloudflare": "next-on-pages",
         "start": "next start",

packages/gitbook/src/components/Ads/renderAd.tsx

@@ -67,7 +67,7 @@ export async function renderAd(options: FetchAdOptions) {
 
 async function fetchAd({ zoneId, placement, ignore }: FetchAdOptions): Promise<AdItem | null> {
     const headersSet = headers();
-    const ip = headersSet.get('x-forwarded-for') ?? '';
+    const ip = headersSet.get('cf-connecting-ip') ?? headersSet.get('x-forwarded-for') ?? '';
     const userAgent = headersSet.get('user-agent') ?? '';
 
     const url = new URL(`https://srv.buysellads.com/ads/${zoneId}.json`);