hotfix: Fix an issue where Ask AI was crashing on some requests.

Author: emmerich

packages/gitbook/src/components/Search/SearchAskAnswer.tsx

@@ -167,16 +167,16 @@ function AnswerBody(props: { answer: AskAnswerResult }) {
                     'dark:text-light/8',
                 )}
             >
-                {answer.hasAnswer ? answer.body : t(language, 'search_ask_no_answer')}
+                {answer.body ?? t(language, 'search_ask_no_answer')}
                 {answer.followupQuestions.length > 0 ? (
                     <AnswerFollowupQuestions followupQuestions={answer.followupQuestions} />
                 ) : null}
             </div>
             {answer.sources.length > 0 ? (
                 <AnswerSources
-                    hasAnswer={answer.hasAnswer}
                     sources={answer.sources}
                     language={language}
+                    hasAnswer={Boolean(answer.body)}
                 />
             ) : null}
         </>
@@ -233,7 +233,7 @@ function AnswerFollowupQuestions(props: { followupQuestions: string[] }) {
 function AnswerSources(props: {
     sources: AskAnswerSource[];
     language: TranslationLanguage;
-    hasAnswer?: boolean;
+    hasAnswer: boolean;
 }) {
     const { sources, language, hasAnswer } = props;
 

packages/gitbook/src/components/Search/server-actions.tsx

@@ -40,10 +40,10 @@ export interface AskAnswerSource {
 }
 
 export interface AskAnswerResult {
+    /** Undefined if no answer. */
     body?: React.ReactNode;
     followupQuestions: string[];
     sources: AskAnswerSource[];
-    hasAnswer: boolean;
 }
 
 /**
@@ -181,7 +181,12 @@ export const streamAskQuestion = streamResponse(async function* (
 
     const spaceData = new Map<string, RevisionPage[]>();
     for await (const chunk of stream) {
-        yield transformAnswer(chunk.answer, spaceData);
+        if (!chunk) {
+            continue;
+        }
+
+        const encoded = await transformAnswer(chunk.answer, spaceData);
+        yield encoded;
     }
 });
 
@@ -223,7 +228,7 @@ async function transformAnswer(
             const { pages } = await api.getSpaceContentData({ spaceId }, undefined);
             spaceData.set(spaceId, pages);
         },
-        { concurrency: 3 },
+        { concurrency: 1 },
     );
 
     const sources = answer.sources
@@ -267,7 +272,6 @@ async function transformAnswer(
             ) : null,
         followupQuestions: answer.followupQuestions,
         sources,
-        hasAnswer: !!answer.answer && 'document' in answer.answer,
     };
 }