updates to use lts-latest for .NET version and distro-latest for docker distributions
#4716
Conversation
…docker distributions
Abstracts common docker build setup logic into `DockerBuildContext` and `DockerBuildLifetime` base classes. Simplifies `BuildContext` and `BuildLifetime` implementations in `artifacts` and `docker` by reusing the shared base classes.
There was a problem hiding this comment.
Pull Request Overview
This pull request introduces a standardized approach for specifying .NET and Docker versions using "latest" keywords (lts-latest and distro-latest) instead of hardcoded version strings, improving maintainability and ensuring builds automatically use the most recent supported versions.
Key changes:
- Renamed constant from
VersionLatesttoDotnetLtsLatestfor clarity - Added logic to recognize and substitute
lts-latestanddistro-latestkeywords with actual version values - Consolidated Docker build setup code by introducing shared
DockerBuildLifetimeandDockerBuildContextbase classes
Reviewed Changes
Copilot reviewed 26 out of 26 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| build/common/Utilities/Constants.cs | Renamed constant from VersionLatest to DotnetLtsLatest |
| build/common/Lifetime/DockerBuildLifetime.cs | New base class with logic to handle lts-latest and distro-latest keywords |
| build/common/Context/DockerBuildContext.cs | New shared context class for Docker-related build properties |
| build/docker/BuildLifetime.cs | Refactored to inherit from DockerBuildLifetime |
| build/artifacts/BuildLifetime.cs | Refactored to inherit from DockerBuildLifetime |
| build/build/Tasks/Test/UnitTest.cs | Added keyword substitution logic for lts-latest |
| build/.run/*.run.xml | Updated run configurations to use new keywords |
| build/docker/Dockerfile | Updated VERSION argument (unrelated version bump) |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
|
Thank you @arturcic for your contribution! |
|
🎉 This issue has been resolved in version 6.5.0 🎉 Your GitReleaseManager bot 📦🚀 |
2 participants
This pull request updates the build and test scripts to consistently use the latest supported .NET LTS version and the latest supported Docker distribution when specified. It introduces new constants for these "latest" values and updates logic and run configurations to recognize and substitute the new keywords (
lts-latestanddistro-latest) for the correct version identifiers. This ensures that builds and tests will always use the most recent LTS .NET and Docker images when requested, improving maintainability and future-proofing the build system.Build and Docker configuration improvements:
build/.run/to accept--dotnet_version=lts-latestand--docker_distro=distro-latestparameters, replacing hardcoded version and distro values. [1] [2] [3] [4] [5] [6] [7] [8] [9] [10] [11]Constants and version handling:
DotnetLtsLatestinConstants.csand replaced usages ofVersionLatestwith this new constant throughout the codebase. Also updated arrays and logic to use the new constant for LTS version handling.BuildLifetime.cs,BuildLifetimeBase.cs,BuildPrepare.cs,PackagePrepare.cs,UnitTest.cs,DockerContextExtensions.cs,Docker/BuildLifetime.cs,ContextExtensions.cs) to recognizelts-latestanddistro-latestas special keywords and substitute them with the correct version/distro values. [1] [2] [3] [4] [5] [6] [7] [8] [9]Codebase consistency and maintainability:
These changes make it easier to keep the build infrastructure up to date with the latest supported platforms and simplify the process for developers to use the newest LTS versions.