Skip to content

Conversation

arturcic
Copy link
Member

@arturcic arturcic commented Feb 8, 2021

Fixes #2587

@arturcic arturcic marked this pull request as draft February 8, 2021 10:41
@arturcic arturcic force-pushed the fix/GH-2587-master-as-source branch from 9f37b52 to eed614f Compare February 8, 2021 10:45
@arturcic arturcic marked this pull request as ready for review February 8, 2021 11:47
@arturcic arturcic merged commit 80adc3f into GitTools:main Feb 8, 2021
@arturcic arturcic linked an issue Feb 8, 2021 that may be closed by this pull request
@arturcic arturcic deleted the fix/GH-2587-master-as-source branch February 8, 2021 20:50
@neslekkim
Copy link

neslekkim commented Feb 10, 2021

Who is responsible for the portable version that chocolatey downloads?, this main/master thing broke all our builds now, and chcolatey tells me that 5.6.5 is latest portable?

@arturcic
Copy link
Member Author

this main/master thing broke all our builds now, and chcolatey tells me that 5.6.5 is latest portable?

I think best approach is to have a version specified instead of always installing the latest version. That's a common practice. Then you test the latest version and then gradually update to latest released.

I will check why the chocolatey version was not published but I recommend to pin the version of any tool so that you have always stable builds. It's a bit frustrating to see this kind of comments

@neslekkim
Copy link

I think best approach is to have a version specified instead of always installing the latest version. That's a common practice. Then you test the latest version and then gradually update to latest released.

Yes, I agreee to this, it have happened a couple of times during the years, and I still have somewhere it autouppgrades, need to check out what happens :)

@arturcic
Copy link
Member Author

pushed https://chocolatey.org/packages/GitVersion.Portable/5.6.6, waiting for moderation to complete

@neslekkim
Copy link

Regarding this:

That's a common practice.
Yes, I would agree, at the same time, since we use TeamCity, we used this many years ago: https://gitversion.readthedocs.io/en/latest/input/docs/build-server-support/build-server/teamcity/
Which pointed us to this one: https://github.com/JetBrains/meta-runner-power-pack/tree/master/gitversion

I think the basic usage would be better, than the meta runner, since the metarunner have the chocolatey integration (only reason we also installed chocolatey), not sure why we didn't use commandline runner, I think we did at some point though.

@arturcic
Copy link
Member Author

We need to update that.
https://gitversion.readthedocs.io is the old resource, this is the new one https://gitversion.net/docs/build-server-support/build-server/teamcity but still we need to update

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] Accidental Breacking change with source-branches config [Bug] 5.6.5 Does not recognise master as a source-branch
2 participants