Skip to content

Commit f5b6b67

Browse files
Andy Furnissarturcic
Andy Furniss
authored andcommitted
Condense code change to avoid repetition
1 parent 369fa11 commit f5b6b67

File tree

1 file changed

+3
-7
lines changed

1 file changed

+3
-7
lines changed

src/GitVersionCore/VersionCalculation/BaseVersionCalculator.cs

Lines changed: 3 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -61,18 +61,14 @@ public BaseVersion GetBaseVersion()
6161

6262
FixTheBaseVersionSourceOfMergeMessageStrategyIfReleaseBranchWasMergedAndDeleted(baseVersions);
6363

64-
Versions maxVersion;
6564
if (context.Configuration.VersioningMode == VersioningMode.Mainline)
6665
{
67-
maxVersion = baseVersions
66+
baseVersions = baseVersions
6867
.Where(b => !b.IncrementedVersion.PreReleaseTag.HasTag())
69-
.Aggregate((v1, v2) => v1.IncrementedVersion > v2.IncrementedVersion ? v1 : v2);
70-
}
71-
else
72-
{
73-
maxVersion = baseVersions.Aggregate((v1, v2) => v1.IncrementedVersion > v2.IncrementedVersion ? v1 : v2);
68+
.ToList();
7469
}
7570

71+
var maxVersion = baseVersions.Aggregate((v1, v2) => v1.IncrementedVersion > v2.IncrementedVersion ? v1 : v2);
7672
var matchingVersionsOnceIncremented = baseVersions
7773
.Where(b => b.Version.BaseVersionSource != null && b.IncrementedVersion == maxVersion.IncrementedVersion)
7874
.ToList();

0 commit comments

Comments
 (0)