added IRemoteCollection

Author: arturcic

src/GitVersion.LibGit2Sharp/Git/GitRepository.cs

@@ -69,10 +69,7 @@ public void Dispose()
         public string Path => repositoryInstance.Info.Path;
         public string WorkingDirectory => repositoryInstance.Info.WorkingDirectory;
         public bool IsHeadDetached => repositoryInstance.Info.IsHeadDetached;
-        public IGitRepository CreateNew(string gitRootPath)
-        {
-            return new GitRepository(new NullLog(), () => gitRootPath);
-        }
+        public IGitRepository CreateNew(string gitRootPath) => new GitRepository(new NullLog(), () => gitRootPath);
         public int GetNumberOfUncommittedChanges()
         {
             // check if we have a branch tip at all to behave properly with empty repos
@@ -116,9 +113,9 @@ public string ShortenObjectId(ICommit commit)
 
         public ITagCollection Tags => new TagCollection(repositoryInstance.Tags);
         public IReferenceCollection Refs => new ReferenceCollection(repositoryInstance.Refs);
-
         public IBranchCollection Branches => new BranchCollection(repositoryInstance.Branches);
         public ICommitCollection Commits => new CommitCollection(repositoryInstance.Commits);
+        public IRemoteCollection Remotes => new RemoteCollection(repositoryInstance.Network.Remotes);
 
         public void CreateBranchForPullRequestBranch(AuthenticationInfo auth)
         {
@@ -176,7 +173,7 @@ public void CreateBranchForPullRequestBranch(AuthenticationInfo auth)
             log.Info($"Checking local branch '{fakeBranchName}' out.");
             Checkout(fakeBranchName);
         }
-        public bool GitRepoHasMatchingRemote(string targetUrl)
+        public bool AnyMatchingRemote(string targetUrl)
         {
             return repositoryInstance.Network.Remotes.Any(r => r.Url == targetUrl);
         }

src/GitVersion.LibGit2Sharp/Git/GitRepositoryInfo.cs

@@ -102,7 +102,7 @@ private static bool GitRepoHasMatchingRemote(string possiblePath, string targetU
         {
             try
             {
-                return new GitRepository(new NullLog(), possiblePath).GitRepoHasMatchingRemote(targetUrl);
+                return new GitRepository(new NullLog(), possiblePath).AnyMatchingRemote(targetUrl);
             }
             catch (Exception)
             {

src/GitVersion.LibGit2Sharp/Git/ReferenceCollection.cs

@@ -25,12 +25,13 @@ public void UpdateTarget(IReference directRef, IObjectId targetId)
         }
 
         IEnumerator IEnumerable.GetEnumerator() => GetEnumerator();
+
         public IReference? this[string name]
         {
             get
             {
-                var branch = innerCollection[name];
-                return branch is null ? null : new Reference(branch);
+                var reference = innerCollection[name];
+                return reference is null ? null : new Reference(reference);
             }
         }
 

src/GitVersion.LibGit2Sharp/Git/RemoteCollection.cs

@@ -0,0 +1,27 @@
+using System.Collections;
+using System.Collections.Generic;
+using System.Linq;
+
+namespace GitVersion
+{
+    internal sealed class RemoteCollection : IRemoteCollection
+    {
+        private readonly LibGit2Sharp.RemoteCollection innerCollection;
+        internal RemoteCollection(LibGit2Sharp.RemoteCollection collection) => innerCollection = collection;
+
+        public IEnumerator<IRemote> GetEnumerator()
+        {
+            return innerCollection.Select(reference => new Remote(reference)).GetEnumerator();
+        }
+        IEnumerator IEnumerable.GetEnumerator() => GetEnumerator();
+
+        public IRemote? this[string name]
+        {
+            get
+            {
+                var remote = innerCollection[name];
+                return remote is null ? null : new Remote(remote);
+            }
+        }
+    }
+}

src/GitVersionCore/Git/IGitRepository.cs

@@ -13,13 +13,13 @@ public interface IGitRepository : IDisposable
         IReferenceCollection Refs { get; }
         IBranchCollection Branches { get; }
         ICommitCollection Commits { get; }
+        IRemoteCollection Remotes { get; }
 
         IGitRepository CreateNew(string gitRootPath);
 
         int GetNumberOfUncommittedChanges();
         string ShortenObjectId(ICommit commit);
 
-        bool GitRepoHasMatchingRemote(string targetUrl);
         void CleanupDuplicateOrigin(string gitRootPath, string remoteName);
         bool GetMatchingCommitBranch(ICommit baseVersionSource, IBranch branch, ICommit firstMatchingCommit);
         IRemote EnsureOnlyOneRemoteIsDefined();

src/GitVersionCore/Git/IRemoteCollection.cs

@@ -0,0 +1,9 @@
+using System.Collections.Generic;
+
+namespace GitVersion
+{
+    public interface IRemoteCollection : IEnumerable<IRemote>
+    {
+        IRemote this[string name] { get; }
+    }
+}