use TryParse

Author: james-bjss

src/GitVersion.Core/VersionCalculation/SemanticVersioning/SemanticVersion.cs

@@ -6,7 +6,6 @@ namespace GitVersion
     public class SemanticVersion : IFormattable, IComparable<SemanticVersion>
     {
         private static SemanticVersion Empty = new SemanticVersion();
-
         private static readonly Regex ParseSemVer = new Regex(
             @"^(?<SemVer>(?<Major>\d+)?(\.(?<Minor>\d+))?(\.(?<Patch>\d+))?)(\.(?<FourthPart>\d+))?(-(?<Tag>[^\+]*))?(\+(?<BuildMetaData>.*))?$",
             RegexOptions.Compiled);
@@ -147,10 +146,10 @@ public static SemanticVersion Parse(string version, string tagPrefixRegex)
         public static bool TryParse(string version, string tagPrefixRegex, out SemanticVersion semanticVersion)
         {
             var match = Regex.Match(version, $"^({tagPrefixRegex})?(?<version>.*)$");
+            semanticVersion = null;
 
             if (!match.Success)
             {
-                semanticVersion = null;
                 return false;
             }
 
@@ -159,45 +158,47 @@ public static bool TryParse(string version, string tagPrefixRegex, out SemanticV
 
             if (!parsed.Success)
             {
-                semanticVersion = null;
                 return false;
             }
 
             var semanticVersionBuildMetaData = SemanticVersionBuildMetaData.Parse(parsed.Groups["BuildMetaData"].Value);
             var fourthPart = parsed.Groups["FourthPart"];
             if (fourthPart.Success && semanticVersionBuildMetaData.CommitsSinceTag == null)
             {
-                semanticVersionBuildMetaData.CommitsSinceTag = int.Parse(fourthPart.Value);
+                semanticVersionBuildMetaData.CommitsSinceTag = Int32.Parse(fourthPart.Value);
             }
 
-            try
+            int major = 0, minor = 0, patch = 0;
+
+            if (!parsed.Groups["Major"].Success || !Int32.TryParse(parsed.Groups["Major"].Value, out major))
             {
-                semanticVersion = new SemanticVersion
-                {
-                    Major = int.Parse(parsed.Groups["Major"].Value),
-                    Minor = parsed.Groups["Minor"].Success ? int.Parse(parsed.Groups["Minor"].Value) : 0,
-                    Patch = parsed.Groups["Patch"].Success ? int.Parse(parsed.Groups["Patch"].Value) : 0,
-                    PreReleaseTag = SemanticVersionPreReleaseTag.Parse(parsed.Groups["Tag"].Value),
-                    BuildMetaData = semanticVersionBuildMetaData
-                };
+                return false;
             }
-            catch (Exception exception)
-            {
-                if (exception is FormatException || exception is OverflowException)
-                {
-                    Console.Error.WriteLine("Failed to Parse Tag:");
-                    Console.Error.WriteLine(exception.Message);
-
-                    semanticVersion = null;
-                    return false;
-                }
 
-                throw exception;
+            if (parsed.Groups["Minor"].Success && !Int32.TryParse(parsed.Groups["Minor"].Value, out minor))
+            {
+                return false;
+            }
+            
+            if (parsed.Groups["Patch"].Success && !Int32.TryParse(parsed.Groups["Patch"].Value, out patch))
+            {
+                return false;
             }
 
+            semanticVersion = new SemanticVersion
+            {
+                Major = major,
+                Minor = minor,
+                Patch = patch,
+                PreReleaseTag = SemanticVersionPreReleaseTag.Parse(parsed.Groups["Tag"].Value),
+                BuildMetaData = semanticVersionBuildMetaData
+            };
+
             return true;
         }
 
+
+
         public int CompareTo(SemanticVersion value)
         {
             return CompareTo(value, true);