cleanup

Author: arturcic

src/GitVersion.App.Tests/Helpers/ProgramFixture.cs

@@ -8,7 +8,7 @@ namespace GitVersion.App.Tests;
 public sealed class ProgramFixture
 {
     private readonly IEnvironment environment;
-    private List<Action<IServiceCollection>> Overrides { get; } = new();
+    private List<Action<IServiceCollection>> Overrides { get; } = [];
     private readonly Lazy<string> logger;
     private readonly Lazy<string?> output;
 

src/GitVersion.App/OverrideConfigurationOptionParser.cs

@@ -4,7 +4,7 @@ namespace GitVersion;
 
 internal class OverrideConfigurationOptionParser
 {
-    private readonly Dictionary<object, object?> overrideConfiguration = new();
+    private readonly Dictionary<object, object?> overrideConfiguration = [];
 
     private static readonly Lazy<ILookup<string?, PropertyInfo>> _lazySupportedProperties =
         new(GetSupportedProperties, true);

src/GitVersion.BuildAgents.Tests/Agents/BuildServerBaseTests.cs

@@ -43,7 +43,7 @@ public void BuildNumberIsFullSemVer()
 
         writes[1].ShouldBe("1.2.3-beta.1+5");
 
-        writes = new List<string?>();
+        writes = [];
         buildAgent.WriteIntegration(writes.Add, variables, false);
         writes.ShouldNotContain(x => x != null && x.StartsWith("Executing GenerateSetVersionMessage for "));
     }

src/GitVersion.BuildAgents/Agents/BuildKite.cs

@@ -27,7 +27,7 @@ public override string[] GenerateSetParameterMessage(string name, string? value)
 
         // For pull requests BUILDKITE_BRANCH refers to the head, so adjust the
         // branch name for pull request versioning to function as expected
-        return string.Format("refs/pull/{0}/head", pullRequest);
+        return $"refs/pull/{pullRequest}/head";
     }
 
     public override bool PreventFetch() => true;

src/GitVersion.Configuration/BranchConfiguration.cs

@@ -53,14 +53,14 @@ internal record BranchConfiguration : IBranchConfiguration
 
     [JsonPropertyName("source-branches")]
     [JsonPropertyDescription("The source branches for this branch.")]
-    public HashSet<string> SourceBranches { get; internal set; } = new();
+    public HashSet<string> SourceBranches { get; internal set; } = [];
 
     [JsonIgnore]
     IReadOnlyCollection<string> IBranchConfiguration.SourceBranches => SourceBranches;
 
     [JsonPropertyName("is-source-branch-for")]
     [JsonPropertyDescription("The branches that this branch is a source branch.")]
-    public HashSet<string> IsSourceBranchFor { get; internal set; } = new();
+    public HashSet<string> IsSourceBranchFor { get; internal set; } = [];
 
     [JsonIgnore]
     IReadOnlyCollection<string> IBranchConfiguration.IsSourceBranchFor => IsSourceBranchFor;

src/GitVersion.Configuration/ConfigurationBuilderBase.cs

@@ -25,9 +25,9 @@ internal abstract class ConfigurationBuilderBase<TConfigurationBuilder> : IConfi
     private bool updateBuildNumber;
     private SemanticVersionFormat semanticVersionFormat;
     private VersionStrategies[] versionStrategies;
-    private Dictionary<string, string> mergeMessageFormats = new();
-    private readonly List<IReadOnlyDictionary<object, object?>> overrides = new();
-    private readonly Dictionary<string, BranchConfigurationBuilder> branchConfigurationBuilders = new();
+    private Dictionary<string, string> mergeMessageFormats = [];
+    private readonly List<IReadOnlyDictionary<object, object?>> overrides = [];
+    private readonly Dictionary<string, BranchConfigurationBuilder> branchConfigurationBuilders = [];
     private DeploymentMode? versioningMode;
     private string? label;
     private IncrementStrategy increment = IncrementStrategy.Inherit;
@@ -384,7 +384,7 @@ public void AddOverride(IReadOnlyDictionary<object, object?> value)
 
     public virtual IGitVersionConfiguration Build()
     {
-        Dictionary<string, BranchConfiguration> branches = new();
+        Dictionary<string, BranchConfiguration> branches = [];
         foreach (var (name, branchConfigurationBuilder) in this.branchConfigurationBuilders)
         {
             branches.Add(name, (BranchConfiguration)branchConfigurationBuilder.Build());

src/GitVersion.Configuration/ConfigurationHelper.cs

@@ -72,7 +72,7 @@ private static void Merge(IDictionary<object, object?> dictionary, IReadOnlyDict
             {
                 if (!dictionary.ContainsKey(item.Key))
                 {
-                    Dictionary<object, object?> anotherDictionaryValue = new();
+                    Dictionary<object, object?> anotherDictionaryValue = [];
                     Merge(anotherDictionaryValue, dictionaryValue);
                     dictionary.Add(item.Key, anotherDictionaryValue);
                 }

src/GitVersion.Configuration/ConfigurationSerializer.cs

@@ -28,23 +28,23 @@ public static IGitVersionConfiguration Read(TextReader reader)
 
     public static void Write(IGitVersionConfiguration configuration, TextWriter writer)
         => Serializer.Serialize(writer, configuration);
-}
 
-internal sealed class JsonPropertyNameInspector(ITypeInspector innerTypeDescriptor) : TypeInspectorSkeleton
-{
-    public override IEnumerable<IPropertyDescriptor> GetProperties(Type type, object? container) =>
-        innerTypeDescriptor.GetProperties(type, container)
-            .Where(p => p.GetCustomAttribute<JsonIgnoreAttribute>() == null)
-            .Select(p =>
-            {
-                var descriptor = new PropertyDescriptor(p);
-                var member = p.GetCustomAttribute<JsonPropertyNameAttribute>();
-                if (member is { Name: not null })
+    private sealed class JsonPropertyNameInspector(ITypeInspector innerTypeDescriptor) : TypeInspectorSkeleton
+    {
+        public override IEnumerable<IPropertyDescriptor> GetProperties(Type type, object? container) =>
+            innerTypeDescriptor.GetProperties(type, container)
+                .Where(p => p.GetCustomAttribute<JsonIgnoreAttribute>() == null)
+                .Select(p =>
                 {
-                    descriptor.Name = member.Name;
-                }
-
-                return (IPropertyDescriptor)descriptor;
-            })
-            .OrderBy(p => p.Order);
+                    var descriptor = new PropertyDescriptor(p);
+                    var member = p.GetCustomAttribute<JsonPropertyNameAttribute>();
+                    if (member is { Name: not null })
+                    {
+                        descriptor.Name = member.Name;
+                    }
+
+                    return (IPropertyDescriptor)descriptor;
+                })
+                .OrderBy(p => p.Order);
+    }
 }

src/GitVersion.Configuration/GitVersionCacheKeyFactory.cs

@@ -32,7 +32,7 @@ public GitVersionCacheKey Create(IReadOnlyDictionary<object, object?>? overrideC
         var overrideConfigHash = GetOverrideConfigHash(overrideConfiguration);
 
         var compositeHash = GetHash(gitSystemHash, configFileHash, repositorySnapshotHash, overrideConfigHash);
-        return new GitVersionCacheKey(compositeHash);
+        return new(compositeHash);
     }
 
     private string GetGitSystemHash()

src/GitVersion.Configuration/GitVersionConfiguration.cs

@@ -109,7 +109,7 @@ public string? NextVersion
 
     [JsonPropertyName("merge-message-formats")]
     [JsonPropertyDescription("Custom merge message formats to enable identification of merge messages that do not follow the built-in conventions.")]
-    public Dictionary<string, string> MergeMessageFormats { get; internal set; } = new();
+    public Dictionary<string, string> MergeMessageFormats { get; internal set; } = [];
 
     [JsonIgnore]
     IReadOnlyDictionary<string, string> IGitVersionConfiguration.MergeMessageFormats => MergeMessageFormats;
@@ -138,7 +138,7 @@ IReadOnlyDictionary<string, IBranchConfiguration> IGitVersionConfiguration.Branc
 
     [JsonPropertyName("branches")]
     [JsonPropertyDescription("The header for all the individual branch configuration.")]
-    public Dictionary<string, BranchConfiguration> Branches { get; internal set; } = new();
+    public Dictionary<string, BranchConfiguration> Branches { get; internal set; } = [];
 
     [JsonIgnore]
     IIgnoreConfiguration IGitVersionConfiguration.Ignore => Ignore;