Merge pull request #2759 from Evangelink/add-readonly

Make fields `readonly` where applicable

Author: asbjornu

src/GitVersion.App.Tests/Helpers/ProgramFixture.cs

@@ -12,7 +12,7 @@ namespace GitVersion.App.Tests
 {
     public sealed class ProgramFixture
     {
-        private IEnvironment environment;
+        private readonly IEnvironment environment;
         public List<Action<IServiceCollection>> Overrides { get; } = new List<Action<IServiceCollection>>();
         private readonly Lazy<string> logger;
         private readonly Lazy<string> output;

src/GitVersion.App/GlobbingResolver.cs

@@ -9,7 +9,7 @@ namespace GitVersion
 {
     public class GlobbingResolver : IGlobbingResolver
     {
-        private Matcher matcher = new Matcher(StringComparison.OrdinalIgnoreCase);
+        private readonly Matcher matcher = new Matcher(StringComparison.OrdinalIgnoreCase);
 
         public IEnumerable<string> Resolve(string workingDirectory, string pattern)
         {

src/GitVersion.App/OverrideConfigOptionParser.cs

@@ -10,7 +10,7 @@ internal class OverrideConfigOptionParser
         private static readonly Lazy<ILookup<string, PropertyInfo>> _lazySupportedProperties =
             new Lazy<ILookup<string, PropertyInfo>>(GetSupportedProperties, true);
 
-        private Lazy<Config> _lazyConfig = new Lazy<Config>();
+        private readonly Lazy<Config> _lazyConfig = new Lazy<Config>();
 
         internal ILookup<string, PropertyInfo> SupportedProperties => _lazySupportedProperties.Value;
 

src/GitVersion.Core/Core/GitPreparer.cs

@@ -20,7 +20,7 @@ public class GitPreparer : IGitPreparer
         private readonly IGitRepositoryInfo repositoryInfo;
         private readonly IRepositoryStore repositoryStore;
         private readonly ICurrentBuildAgent buildAgent;
-        private RetryAction<LockedFileException> retryAction;
+        private readonly RetryAction<LockedFileException> retryAction;
 
         private const string DefaultRemoteName = "origin";
 

src/GitVersion.Core/Helpers/RetryAction.cs

@@ -24,7 +24,7 @@ public void Execute(Action operation)
     }
     public class RetryAction<T, Result> where T : Exception
     {
-        private RetryPolicy<Result> retryPolicy;
+        private readonly RetryPolicy<Result> retryPolicy;
 
         public RetryAction(int maxRetries = 5)
         {

src/GitVersion.Core/VersionCalculation/BaseVersionCalculators/VersionInBranchNameVersionStrategy.cs

@@ -13,7 +13,7 @@ namespace GitVersion.VersionCalculation
     /// </summary>
     public class VersionInBranchNameVersionStrategy : VersionStrategyBase
     {
-        private IRepositoryStore repositoryStore;
+        private readonly IRepositoryStore repositoryStore;
 
         public VersionInBranchNameVersionStrategy(IRepositoryStore repositoryStore, Lazy<GitVersionContext> versionContext) : base(versionContext)
         {

src/GitVersion.LibGit2Sharp/Git/GitRepository.cs

@@ -11,7 +11,7 @@ namespace GitVersion
     internal sealed class GitRepository : IMutatingGitRepository
     {
         private readonly ILog log;
-        private Lazy<IRepository> repositoryLazy;
+        private readonly Lazy<IRepository> repositoryLazy;
         private IRepository repositoryInstance => repositoryLazy.Value;
 
         public GitRepository(ILog log, IGitRepositoryInfo repositoryInfo)

src/GitVersion.LibGit2Sharp/Git/GitRepositoryInfo.cs

@@ -10,10 +10,10 @@ internal class GitRepositoryInfo : IGitRepositoryInfo
         private readonly IOptions<GitVersionOptions> options;
         private GitVersionOptions gitVersionOptions => options.Value;
 
-        private Lazy<string?> dynamicGitRepositoryPath;
-        private Lazy<string?> dotGitDirectory;
-        private Lazy<string?> gitRootPath;
-        private Lazy<string> projectRootDirectory;
+        private readonly Lazy<string?> dynamicGitRepositoryPath;
+        private readonly Lazy<string?> dotGitDirectory;
+        private readonly Lazy<string?> gitRootPath;
+        private readonly Lazy<string> projectRootDirectory;
 
         public GitRepositoryInfo(IOptions<GitVersionOptions> options)
         {