Enabled PHP 5.5 and 5.6 rector rules

Author: GrahamCampbell

rector.yml

@@ -14,6 +14,8 @@ parameters:
         - 'php52'
         - 'php53'
         - 'php54'
+        - 'php55'
+        - 'php56'
 
 services:
     Rector\SOLID\Rector\Foreach_\ChangeNestedForeachIfsToEarlyContinueRector: ~

test/Gitlab/Tests/Api/AbstractApiTest.php

@@ -2,6 +2,7 @@
 
 namespace Gitlab\Tests\Api;
 
+use Gitlab\Api\AbstractApi;
 use Gitlab\Client;
 use Http\Client\HttpClient;
 use PHPUnit\Framework\TestCase;
@@ -48,7 +49,7 @@ protected function getAbstractApiMock(array $methods = [])
         ;
         $client = Client::createWithHttpClient($httpClient);
 
-        return $this->getMockBuilder('Gitlab\Api\AbstractApi')
+        return $this->getMockBuilder(AbstractApi::class)
             ->setConstructorArgs([
                 $client,
                 null,

test/Gitlab/Tests/Api/DeployKeysTest.php

@@ -2,6 +2,7 @@
 
 namespace Gitlab\Tests\Api;
 
+use Gitlab\Api\DeployKeys;
 class DeployKeysTest extends TestCase
 {
     /**
@@ -41,6 +42,6 @@ protected function getMultipleDeployKeysData()
 
     protected function getApiClass()
     {
-        return 'Gitlab\Api\DeployKeys';
+        return DeployKeys::class;
     }
 }

test/Gitlab/Tests/Api/DeploymentsTest.php

@@ -2,6 +2,7 @@
 
 namespace Gitlab\Tests\Api;
 
+use Gitlab\Api\Deployments;
 class DeploymentsTest extends TestCase
 {
     /**
@@ -230,6 +231,6 @@ public function shouldShowDeployment()
 
     protected function getApiClass()
     {
-        return 'Gitlab\Api\Deployments';
+        return Deployments::class;
     }
 }

test/Gitlab/Tests/Api/EnvironmentsTest.php

@@ -2,6 +2,7 @@
 
 namespace Gitlab\Tests\Api;
 
+use Gitlab\Api\Environments;
 class EnvironmentsTest extends TestCase
 {
     /**
@@ -190,6 +191,6 @@ public function shouldStopEnvironment()
 
     protected function getApiClass()
     {
-        return 'Gitlab\Api\Environments';
+        return Environments::class;
     }
 }

test/Gitlab/Tests/Api/GroupBoardsTest.php

@@ -2,6 +2,7 @@
 
 namespace Gitlab\Tests\Api;
 
+use Gitlab\Api\GroupsBoards;
 class GroupBoardsTest extends TestCase
 {
     /**
@@ -227,6 +228,6 @@ public function shouldDeleteList()
 
     protected function getApiClass()
     {
-        return 'Gitlab\Api\GroupsBoards';
+        return GroupsBoards::class;
     }
 }

test/Gitlab/Tests/Api/GroupsMilestonesTest.php

@@ -2,6 +2,7 @@
 
 namespace Gitlab\Tests\Api;
 
+use Gitlab\Api\GroupsMilestones;
 class GroupsMilestonesTest extends TestCase
 {
     /**
@@ -134,6 +135,6 @@ public function shouldGetMilestonesMergeRequests()
 
     protected function getApiClass()
     {
-        return 'Gitlab\Api\GroupsMilestones';
+        return GroupsMilestones::class;
     }
 }

test/Gitlab/Tests/Api/GroupsTest.php

@@ -2,6 +2,7 @@
 
 namespace Gitlab\Tests\Api;
 
+use Gitlab\Api\Groups;
 class GroupsTest extends TestCase
 {
     /**
@@ -523,7 +524,7 @@ public function shouldRemoveVariable()
 
     protected function getApiClass()
     {
-        return 'Gitlab\Api\Groups';
+        return Groups::class;
     }
 
     /**

test/Gitlab/Tests/Api/IssueBoardsTest.php

@@ -2,6 +2,7 @@
 
 namespace Gitlab\Tests\Api;
 
+use Gitlab\Api\IssueBoards;
 class IssueBoardsTest extends TestCase
 {
     /**
@@ -227,6 +228,6 @@ public function shouldDeleteList()
 
     protected function getApiClass()
     {
-        return 'Gitlab\Api\IssueBoards';
+        return IssueBoards::class;
     }
 }

test/Gitlab/Tests/Api/IssuesTest.php

@@ -2,6 +2,7 @@
 
 namespace Gitlab\Tests\Api;
 
+use Gitlab\Api\Issues;
 class IssuesTest extends TestCase
 {
     /**
@@ -677,6 +678,6 @@ public function shouldGetIssueParticipants()
 
     protected function getApiClass()
     {
-        return 'Gitlab\Api\Issues';
+        return Issues::class;
     }
 }

test/Gitlab/Tests/Api/JobsTest.php

@@ -225,6 +225,6 @@ public function shouldPlay()
 
     protected function getApiClass()
     {
-        return 'Gitlab\Api\Jobs';
+        return Jobs::class;
     }
 }

test/Gitlab/Tests/Api/KeysTest.php

@@ -2,6 +2,7 @@
 
 namespace Gitlab\Tests\Api;
 
+use Gitlab\Api\Keys;
 class KeysTest extends TestCase
 {
     /**
@@ -21,6 +22,6 @@ public function shouldShowKey()
 
     protected function getApiClass()
     {
-        return 'Gitlab\Api\Keys';
+        return Keys::class;
     }
 }

test/Gitlab/Tests/Api/MergeRequestsTest.php

@@ -2,6 +2,7 @@
 
 namespace Gitlab\Tests\Api;
 
+use Gitlab\Api\MergeRequests;
 class MergeRequestsTest extends TestCase
 {
     /**
@@ -839,7 +840,7 @@ protected function getMultipleMergeRequestsData()
 
     protected function getApiClass()
     {
-        return 'Gitlab\Api\MergeRequests';
+        return MergeRequests::class;
     }
 
     /**

test/Gitlab/Tests/Api/MilestonesTest.php

@@ -2,6 +2,7 @@
 
 namespace Gitlab\Tests\Api;
 
+use Gitlab\Api\Milestones;
 class MilestonesTest extends TestCase
 {
     /**
@@ -114,6 +115,6 @@ public function shouldGetMilestonesIssues()
 
     protected function getApiClass()
     {
-        return 'Gitlab\Api\Milestones';
+        return Milestones::class;
     }
 }

test/Gitlab/Tests/Api/ProjectNamespacesTest.php

@@ -2,6 +2,7 @@
 
 namespace Gitlab\Tests\Api;
 
+use Gitlab\Api\ProjectNamespaces;
 class ProjectNamespacesTest extends TestCase
 {
     /**
@@ -43,6 +44,6 @@ public function shouldShowNamespace()
 
     protected function getApiClass()
     {
-        return 'Gitlab\Api\ProjectNamespaces';
+        return ProjectNamespaces::class;
     }
 }

test/Gitlab/Tests/Api/ProjectsTest.php

@@ -2,6 +2,7 @@
 
 namespace Gitlab\Tests\Api;
 
+use Gitlab\Api\Projects;
 class ProjectsTest extends TestCase
 {
     /**
@@ -1996,6 +1997,6 @@ public function shouldDeleteAllMergedBranches()
 
     protected function getApiClass()
     {
-        return 'Gitlab\Api\Projects';
+        return Projects::class;
     }
 }

test/Gitlab/Tests/Api/RepositoriesTest.php

@@ -626,6 +626,6 @@ public function shouldGetMergeBase()
 
     protected function getApiClass()
     {
-        return 'Gitlab\Api\Repositories';
+        return Repositories::class;
     }
 }

test/Gitlab/Tests/Api/ScheduleTest.php

@@ -2,6 +2,7 @@
 
 namespace Gitlab\Tests\Api;
 
+use Gitlab\Api\Schedules;
 class ScheduleTest extends TestCase
 {
     /**
@@ -123,6 +124,6 @@ public function shouldRemoveSchedule()
 
     protected function getApiClass()
     {
-        return 'Gitlab\Api\Schedules';
+        return Schedules::class;
     }
 }

test/Gitlab/Tests/Api/SnippetsTest.php

@@ -2,6 +2,7 @@
 
 namespace Gitlab\Tests\Api;
 
+use Gitlab\Api\Snippets;
 class SnippetsTest extends TestCase
 {
     /**
@@ -236,6 +237,6 @@ public function shouldRevokeSnippetAwardEmoji()
 
     protected function getApiClass()
     {
-        return 'Gitlab\Api\Snippets';
+        return Snippets::class;
     }
 }

test/Gitlab/Tests/Api/SystemHooksTest.php

@@ -2,6 +2,7 @@
 
 namespace Gitlab\Tests\Api;
 
+use Gitlab\Api\SystemHooks;
 class SystemHooksTest extends TestCase
 {
     /**
@@ -77,6 +78,6 @@ public function shouldRemoveHook()
 
     protected function getApiClass()
     {
-        return 'Gitlab\Api\SystemHooks';
+        return SystemHooks::class;
     }
 }

test/Gitlab/Tests/Api/TagsTest.php

@@ -2,6 +2,7 @@
 
 namespace Gitlab\Tests\Api;
 
+use Gitlab\Api\Tags;
 class TagsTest extends TestCase
 {
     /**
@@ -150,6 +151,6 @@ public function releaseDataProvider()
 
     protected function getApiClass()
     {
-        return 'Gitlab\Api\Tags';
+        return Tags::class;
     }
 }

test/Gitlab/Tests/Api/UsersTest.php

@@ -2,6 +2,7 @@
 
 namespace Gitlab\Tests\Api;
 
+use Gitlab\Api\Users;
 class UsersTest extends TestCase
 {
     /**
@@ -721,7 +722,7 @@ public function shouldGetCurrentUserInactiveImpersonationTokens()
 
     protected function getApiClass()
     {
-        return 'Gitlab\Api\Users';
+        return Users::class;
     }
 
     /**

test/Gitlab/Tests/Api/VersionTest.php

@@ -2,6 +2,7 @@
 
 namespace Gitlab\Tests\Api;
 
+use Gitlab\Api\Version;
 class VersionTest extends TestCase
 {
     /**
@@ -24,6 +25,6 @@ public function shouldShowVersion()
 
     protected function getApiClass()
     {
-        return 'Gitlab\Api\Version';
+        return Version::class;
     }
 }

test/Gitlab/Tests/Api/WikiTest.php

@@ -2,6 +2,7 @@
 
 namespace Gitlab\Tests\Api;
 
+use Gitlab\Api\Wiki;
 class WikiTest extends TestCase
 {
     /**
@@ -118,6 +119,6 @@ public function shouldRemoveWiki()
 
     protected function getApiClass()
     {
-        return 'Gitlab\Api\Wiki';
+        return Wiki::class;
     }
 }