Applied fixes from reactor

GrahamCampbell · GrahamCampbell · commit af042f3f86e8 · 2020-07-16T17:11:46.000+01:00
diff --git a/lib/Gitlab/Api/Groups.php b/lib/Gitlab/Api/Groups.php
@@ -422,7 +422,7 @@ private function getGroupSearchResolver()
         $resolver->setDefined('skip_groups')
             ->setAllowedTypes('skip_groups', 'array')
             ->setAllowedValues('skip_groups', function (array $value) {
-                return count($value) == count(array_filter($value, 'is_int'));
+                return count($value) === count(array_filter($value, 'is_int'));
             })
         ;
         $resolver->setDefined('all_available')
diff --git a/lib/Gitlab/Api/GroupsMilestones.php b/lib/Gitlab/Api/GroupsMilestones.php
@@ -25,7 +25,7 @@ public function all($group_id, array $parameters = [])
         $resolver->setDefined('iids')
             ->setAllowedTypes('iids', 'array')
             ->setAllowedValues('iids', function (array $value) {
-                return count($value) == count(array_filter($value, 'is_int'));
+                return count($value) === count(array_filter($value, 'is_int'));
             })
         ;
         $resolver->setDefined('state')
diff --git a/lib/Gitlab/Api/Issues.php b/lib/Gitlab/Api/Issues.php
@@ -515,7 +515,7 @@ protected function createOptionsResolver()
         $resolver->setDefined('iids')
             ->setAllowedTypes('iids', 'array')
             ->setAllowedValues('iids', function (array $value) {
-                return count($value) == count(array_filter($value, 'is_int'));
+                return count($value) === count(array_filter($value, 'is_int'));
             })
         ;
         $resolver->setDefined('scope')
diff --git a/lib/Gitlab/Api/MergeRequests.php b/lib/Gitlab/Api/MergeRequests.php
@@ -48,7 +48,7 @@ public function all($project_id = null, array $parameters = [])
         $resolver->setDefined('iids')
             ->setAllowedTypes('iids', 'array')
             ->setAllowedValues('iids', function (array $value) {
-                return count($value) == count(array_filter($value, 'is_int'));
+                return count($value) === count(array_filter($value, 'is_int'));
             })
         ;
         $resolver->setDefined('state')
diff --git a/lib/Gitlab/Api/Milestones.php b/lib/Gitlab/Api/Milestones.php
@@ -25,7 +25,7 @@ public function all($project_id, array $parameters = [])
         $resolver->setDefined('iids')
             ->setAllowedTypes('iids', 'array')
             ->setAllowedValues('iids', function (array $value) {
-                return count($value) == count(array_filter($value, 'is_int'));
+                return count($value) === count(array_filter($value, 'is_int'));
             })
         ;
         $resolver->setDefined('state')
diff --git a/lib/Gitlab/Api/Projects.php b/lib/Gitlab/Api/Projects.php
@@ -103,7 +103,7 @@ public function show($project_id, array $parameters = [])
     {
         $resolver = $this->createOptionsResolver();
         $booleanNormalizer = function (Options $resolver, $value) {
-            return $value ? true : false;
+            return (bool) $value;
         };
         $resolver->setDefined('statistics')
             ->setAllowedTypes('statistics', 'bool')
diff --git a/lib/Gitlab/Client.php b/lib/Gitlab/Client.php
@@ -2,6 +2,31 @@
 
 namespace Gitlab;
 
+use Gitlab\Api\DeployKeys;
+use Gitlab\Api\Deployments;
+use Gitlab\Api\Environments;
+use Gitlab\Api\Groups;
+use Gitlab\Api\GroupsBoards;
+use Gitlab\Api\GroupsMilestones;
+use Gitlab\Api\IssueBoards;
+use Gitlab\Api\IssueLinks;
+use Gitlab\Api\Issues;
+use Gitlab\Api\IssuesStatistics;
+use Gitlab\Api\Jobs;
+use Gitlab\Api\Keys;
+use Gitlab\Api\MergeRequests;
+use Gitlab\Api\Milestones;
+use Gitlab\Api\ProjectNamespaces;
+use Gitlab\Api\Projects;
+use Gitlab\Api\Repositories;
+use Gitlab\Api\RepositoryFiles;
+use Gitlab\Api\Schedules;
+use Gitlab\Api\Snippets;
+use Gitlab\Api\SystemHooks;
+use Gitlab\Api\Users;
+use Gitlab\Api\Tags;
+use Gitlab\Api\Version;
+use Gitlab\Api\Wiki;
 use Gitlab\Api\AbstractApi;
 use Gitlab\Exception\InvalidArgumentException;
 use Gitlab\HttpClient\Builder;
@@ -155,199 +180,199 @@ public static function createWithHttpClient(HttpClient $httpClient)
      */
     public function deployKeys()
     {
-        return new Api\DeployKeys($this);
+        return new DeployKeys($this);
     }
 
     /**
      * @return Api\Deployments
      */
     public function deployments()
     {
-        return new Api\Deployments($this);
+        return new Deployments($this);
     }
 
     /**
      * @return Api\Environments
      */
     public function environments()
     {
-        return new Api\Environments($this);
+        return new Environments($this);
     }
 
     /**
      * @return Api\Groups
      */
     public function groups()
     {
-        return new Api\Groups($this);
+        return new Groups($this);
     }
 
     /**
      * @return Api\GroupsBoards
      */
     public function groupsBoards()
     {
-        return new Api\GroupsBoards($this);
+        return new GroupsBoards($this);
     }
 
     /**
      * @return Api\GroupsMilestones
      */
     public function groupsMilestones()
     {
-        return new Api\GroupsMilestones($this);
+        return new GroupsMilestones($this);
     }
 
     /**
      * @return Api\IssueBoards
      */
     public function issueBoards()
     {
-        return new Api\IssueBoards($this);
+        return new IssueBoards($this);
     }
 
     /**
      * @return Api\IssueLinks
      */
     public function issueLinks()
     {
-        return new Api\IssueLinks($this);
+        return new IssueLinks($this);
     }
 
     /**
      * @return Api\Issues
      */
     public function issues()
     {
-        return new Api\Issues($this);
+        return new Issues($this);
     }
 
     /**
      * @return Api\IssuesStatistics
      */
     public function issuesStatistics()
     {
-        return new Api\IssuesStatistics($this);
+        return new IssuesStatistics($this);
     }
 
     /**
      * @return Api\Jobs
      */
     public function jobs()
     {
-        return new Api\Jobs($this);
+        return new Jobs($this);
     }
 
     /**
      * @return Api\Keys
      */
     public function keys()
     {
-        return new Api\Keys($this);
+        return new Keys($this);
     }
 
     /**
      * @return Api\MergeRequests
      */
     public function mergeRequests()
     {
-        return new Api\MergeRequests($this);
+        return new MergeRequests($this);
     }
 
     /**
      * @return Api\Milestones
      */
     public function milestones()
     {
-        return new Api\Milestones($this);
+        return new Milestones($this);
     }
 
     /**
      * @return Api\ProjectNamespaces
      */
     public function namespaces()
     {
-        return new Api\ProjectNamespaces($this);
+        return new ProjectNamespaces($this);
     }
 
     /**
      * @return Api\Projects
      */
     public function projects()
     {
-        return new Api\Projects($this);
+        return new Projects($this);
     }
 
     /**
      * @return Api\Repositories
      */
     public function repositories()
     {
-        return new Api\Repositories($this);
+        return new Repositories($this);
     }
 
     /**
      * @return Api\RepositoryFiles
      */
     public function repositoryFiles()
     {
-        return new Api\RepositoryFiles($this);
+        return new RepositoryFiles($this);
     }
 
     /**
      * @return Api\Schedules
      */
     public function schedules()
     {
-        return new Api\Schedules($this);
+        return new Schedules($this);
     }
 
     /**
      * @return Api\Snippets
      */
     public function snippets()
     {
-        return new Api\Snippets($this);
+        return new Snippets($this);
     }
 
     /**
      * @return Api\SystemHooks
      */
     public function systemHooks()
     {
-        return new Api\SystemHooks($this);
+        return new SystemHooks($this);
     }
 
     /**
      * @return Api\Users
      */
     public function users()
     {
-        return new Api\Users($this);
+        return new Users($this);
     }
 
     /**
      * @return Api\Tags
      */
     public function tags()
     {
-        return new Api\Tags($this);
+        return new Tags($this);
     }
 
     /**
      * @return Api\Version
      */
     public function version()
     {
-        return new Api\Version($this);
+        return new Version($this);
     }
 
     /**
      * @return Api\Wiki
      */
     public function wiki()
     {
-        return new Api\Wiki($this);
+        return new Wiki($this);
     }
 
     /**
diff --git a/lib/Gitlab/HttpClient/Plugin/ApiVersion.php b/lib/Gitlab/HttpClient/Plugin/ApiVersion.php
@@ -2,6 +2,7 @@
 
 namespace Gitlab\HttpClient\Plugin;
 
+use Http\Client\Common\Plugin\VersionBridgePlugin;
 use Http\Client\Common\Plugin;
 use Http\Promise\Promise;
 use Psr\Http\Message\RequestInterface;
@@ -18,7 +19,7 @@
  */
 class ApiVersion implements Plugin
 {
-    use Plugin\VersionBridgePlugin;
+    use VersionBridgePlugin;
 
     /**
      * @var bool
diff --git a/lib/Gitlab/HttpClient/Plugin/Authentication.php b/lib/Gitlab/HttpClient/Plugin/Authentication.php
@@ -2,6 +2,7 @@
 
 namespace Gitlab\HttpClient\Plugin;
 
+use Http\Client\Common\Plugin\VersionBridgePlugin;
 use Gitlab\Client;
 use Http\Client\Common\Plugin;
 use Http\Promise\Promise;
@@ -19,7 +20,7 @@
  */
 class Authentication implements Plugin
 {
-    use Plugin\VersionBridgePlugin;
+    use VersionBridgePlugin;
 
     /**
      * @var string
diff --git a/lib/Gitlab/HttpClient/Plugin/GitlabExceptionThrower.php b/lib/Gitlab/HttpClient/Plugin/GitlabExceptionThrower.php
@@ -2,6 +2,7 @@
 
 namespace Gitlab\HttpClient\Plugin;
 
+use Http\Client\Common\Plugin\VersionBridgePlugin;
 use Gitlab\Exception\ApiLimitExceededException;
 use Gitlab\Exception\ErrorException;
 use Gitlab\Exception\RuntimeException;
@@ -24,7 +25,7 @@
  */
 class GitlabExceptionThrower implements Plugin
 {
-    use Plugin\VersionBridgePlugin;
+    use VersionBridgePlugin;
 
     /**
      * Handle the request and return the response coming from the next callable.
diff --git a/lib/Gitlab/ResultPager.php b/lib/Gitlab/ResultPager.php
@@ -167,11 +167,7 @@ protected function postFetch()
     {
         $response = $this->client->getLastResponse();
 
-        if (null === $response) {
-            $this->pagination = [];
-        } else {
-            $this->pagination = ResponseMediator::getPagination($response);
-        }
+        $this->pagination = null === $response ? [] : ResponseMediator::getPagination($response);
     }
 
     /**
diff --git a/test/Gitlab/Tests/Api/AbstractApiTest.php b/test/Gitlab/Tests/Api/AbstractApiTest.php
@@ -48,15 +48,12 @@ protected function getAbstractApiMock(array $methods = [])
         ;
         $client = Client::createWithHttpClient($httpClient);
 
-        $abstractApiMock = $this->getMockBuilder('Gitlab\Api\AbstractApi')
+        return $this->getMockBuilder('Gitlab\Api\AbstractApi')
             ->setConstructorArgs([
                 $client,
                 null,
             ])
             ->setMethods($methods)
-            ->getMockForAbstractClass()
-        ;
-
-        return $abstractApiMock;
+            ->getMockForAbstractClass();
     }
 }
diff --git a/test/Gitlab/Tests/HttpClient/Message/ResponseMediatorTest.php b/test/Gitlab/Tests/HttpClient/Message/ResponseMediatorTest.php
diff --git a/test/Gitlab/Tests/HttpClient/Util/QueryStringBuilderTest.php b/test/Gitlab/Tests/HttpClient/Util/QueryStringBuilderTest.php
diff --git a/test/Gitlab/Tests/Model/ProjectTest.php b/test/Gitlab/Tests/Model/ProjectTest.php

Original file line number	Diff line number	Diff line change
`@@ -422,7 +422,7 @@ private function getGroupSearchResolver()`
`422`	`422`	`$resolver->setDefined('skip_groups')`
`423`	`423`	`->setAllowedTypes('skip_groups', 'array')`
`424`	`424`	`->setAllowedValues('skip_groups', function (array $value) {`
`425`		`- return count($value) == count(array_filter($value, 'is_int'));`
	`425`	`+ return count($value) === count(array_filter($value, 'is_int'));`
`426`	`426`	`})`
`427`	`427`	`;`
`428`	`428`	`$resolver->setDefined('all_available')`
Original file line number	Diff line number	Diff line change
`@@ -25,7 +25,7 @@ public function all($group_id, array $parameters = [])`
`25`	`25`	`$resolver->setDefined('iids')`
`26`	`26`	`->setAllowedTypes('iids', 'array')`
`27`	`27`	`->setAllowedValues('iids', function (array $value) {`
`28`		`- return count($value) == count(array_filter($value, 'is_int'));`
	`28`	`+ return count($value) === count(array_filter($value, 'is_int'));`
`29`	`29`	`})`
`30`	`30`	`;`
`31`	`31`	`$resolver->setDefined('state')`
Original file line number	Diff line number	Diff line change
`@@ -515,7 +515,7 @@ protected function createOptionsResolver()`
`515`	`515`	`$resolver->setDefined('iids')`
`516`	`516`	`->setAllowedTypes('iids', 'array')`
`517`	`517`	`->setAllowedValues('iids', function (array $value) {`
`518`		`- return count($value) == count(array_filter($value, 'is_int'));`
	`518`	`+ return count($value) === count(array_filter($value, 'is_int'));`
`519`	`519`	`})`
`520`	`520`	`;`
`521`	`521`	`$resolver->setDefined('scope')`
Original file line number	Diff line number	Diff line change
`@@ -48,7 +48,7 @@ public function all($project_id = null, array $parameters = [])`
`48`	`48`	`$resolver->setDefined('iids')`
`49`	`49`	`->setAllowedTypes('iids', 'array')`
`50`	`50`	`->setAllowedValues('iids', function (array $value) {`
`51`		`- return count($value) == count(array_filter($value, 'is_int'));`
	`51`	`+ return count($value) === count(array_filter($value, 'is_int'));`
`52`	`52`	`})`
`53`	`53`	`;`
`54`	`54`	`$resolver->setDefined('state')`
Original file line number	Diff line number	Diff line change
`@@ -103,7 +103,7 @@ public function show($project_id, array $parameters = [])`
`103`	`103`	`{`
`104`	`104`	`$resolver = $this->createOptionsResolver();`
`105`	`105`	`$booleanNormalizer = function (Options $resolver, $value) {`
`106`		`- return $value ? true : false;`
	`106`	`+ return (bool) $value;`
`107`	`107`	`};`
`108`	`108`	`$resolver->setDefined('statistics')`
`109`	`109`	`->setAllowedTypes('statistics', 'bool')`
Original file line number	Diff line number	Diff line change
`@@ -2,6 +2,31 @@`
`2`	`2`
`3`	`3`	`namespace Gitlab;`
`4`	`4`
	`5`	`+use Gitlab\Api\DeployKeys;`
	`6`	`+use Gitlab\Api\Deployments;`
	`7`	`+use Gitlab\Api\Environments;`
	`8`	`+use Gitlab\Api\Groups;`
	`9`	`+use Gitlab\Api\GroupsBoards;`
	`10`	`+use Gitlab\Api\GroupsMilestones;`
	`11`	`+use Gitlab\Api\IssueBoards;`
	`12`	`+use Gitlab\Api\IssueLinks;`
	`13`	`+use Gitlab\Api\Issues;`
	`14`	`+use Gitlab\Api\IssuesStatistics;`
	`15`	`+use Gitlab\Api\Jobs;`
	`16`	`+use Gitlab\Api\Keys;`
	`17`	`+use Gitlab\Api\MergeRequests;`
	`18`	`+use Gitlab\Api\Milestones;`
	`19`	`+use Gitlab\Api\ProjectNamespaces;`
	`20`	`+use Gitlab\Api\Projects;`
	`21`	`+use Gitlab\Api\Repositories;`
	`22`	`+use Gitlab\Api\RepositoryFiles;`
	`23`	`+use Gitlab\Api\Schedules;`
	`24`	`+use Gitlab\Api\Snippets;`
	`25`	`+use Gitlab\Api\SystemHooks;`
	`26`	`+use Gitlab\Api\Users;`
	`27`	`+use Gitlab\Api\Tags;`
	`28`	`+use Gitlab\Api\Version;`
	`29`	`+use Gitlab\Api\Wiki;`
`5`	`30`	`use Gitlab\Api\AbstractApi;`
`6`	`31`	`use Gitlab\Exception\InvalidArgumentException;`
`7`	`32`	`use Gitlab\HttpClient\Builder;`
`@@ -155,199 +180,199 @@ public static function createWithHttpClient(HttpClient $httpClient)`
`155`	`180`	`*/`
`156`	`181`	`public function deployKeys()`
`157`	`182`	`{`
`158`		`- return new Api\DeployKeys($this);`
	`183`	`+ return new DeployKeys($this);`
`159`	`184`	`}`
`160`	`185`
`161`	`186`	`/**`
`162`	`187`	`* @return Api\Deployments`
`163`	`188`	`*/`
`164`	`189`	`public function deployments()`
`165`	`190`	`{`
`166`		`- return new Api\Deployments($this);`
	`191`	`+ return new Deployments($this);`
`167`	`192`	`}`
`168`	`193`
`169`	`194`	`/**`
`170`	`195`	`* @return Api\Environments`
`171`	`196`	`*/`
`172`	`197`	`public function environments()`
`173`	`198`	`{`
`174`		`- return new Api\Environments($this);`
	`199`	`+ return new Environments($this);`
`175`	`200`	`}`
`176`	`201`
`177`	`202`	`/**`
`178`	`203`	`* @return Api\Groups`
`179`	`204`	`*/`
`180`	`205`	`public function groups()`
`181`	`206`	`{`
`182`		`- return new Api\Groups($this);`
	`207`	`+ return new Groups($this);`
`183`	`208`	`}`
`184`	`209`
`185`	`210`	`/**`
`186`	`211`	`* @return Api\GroupsBoards`
`187`	`212`	`*/`
`188`	`213`	`public function groupsBoards()`
`189`	`214`	`{`
`190`		`- return new Api\GroupsBoards($this);`
	`215`	`+ return new GroupsBoards($this);`
`191`	`216`	`}`
`192`	`217`
`193`	`218`	`/**`
`194`	`219`	`* @return Api\GroupsMilestones`
`195`	`220`	`*/`
`196`	`221`	`public function groupsMilestones()`
`197`	`222`	`{`
`198`		`- return new Api\GroupsMilestones($this);`
	`223`	`+ return new GroupsMilestones($this);`
`199`	`224`	`}`
`200`	`225`
`201`	`226`	`/**`
`202`	`227`	`* @return Api\IssueBoards`
`203`	`228`	`*/`
`204`	`229`	`public function issueBoards()`
`205`	`230`	`{`
`206`		`- return new Api\IssueBoards($this);`
	`231`	`+ return new IssueBoards($this);`
`207`	`232`	`}`
`208`	`233`
`209`	`234`	`/**`
`210`	`235`	`* @return Api\IssueLinks`
`211`	`236`	`*/`
`212`	`237`	`public function issueLinks()`
`213`	`238`	`{`
`214`		`- return new Api\IssueLinks($this);`
	`239`	`+ return new IssueLinks($this);`
`215`	`240`	`}`
`216`	`241`
`217`	`242`	`/**`
`218`	`243`	`* @return Api\Issues`
`219`	`244`	`*/`
`220`	`245`	`public function issues()`
`221`	`246`	`{`
`222`		`- return new Api\Issues($this);`
	`247`	`+ return new Issues($this);`
`223`	`248`	`}`
`224`	`249`
`225`	`250`	`/**`
`226`	`251`	`* @return Api\IssuesStatistics`
`227`	`252`	`*/`
`228`	`253`	`public function issuesStatistics()`
`229`	`254`	`{`
`230`		`- return new Api\IssuesStatistics($this);`
	`255`	`+ return new IssuesStatistics($this);`
`231`	`256`	`}`
`232`	`257`
`233`	`258`	`/**`
`234`	`259`	`* @return Api\Jobs`
`235`	`260`	`*/`
`236`	`261`	`public function jobs()`
`237`	`262`	`{`
`238`		`- return new Api\Jobs($this);`
	`263`	`+ return new Jobs($this);`
`239`	`264`	`}`
`240`	`265`
`241`	`266`	`/**`
`242`	`267`	`* @return Api\Keys`
`243`	`268`	`*/`
`244`	`269`	`public function keys()`
`245`	`270`	`{`
`246`		`- return new Api\Keys($this);`
	`271`	`+ return new Keys($this);`
`247`	`272`	`}`
`248`	`273`
`249`	`274`	`/**`
`250`	`275`	`* @return Api\MergeRequests`
`251`	`276`	`*/`
`252`	`277`	`public function mergeRequests()`
`253`	`278`	`{`
`254`		`- return new Api\MergeRequests($this);`
	`279`	`+ return new MergeRequests($this);`
`255`	`280`	`}`
`256`	`281`
`257`	`282`	`/**`
`258`	`283`	`* @return Api\Milestones`
`259`	`284`	`*/`
`260`	`285`	`public function milestones()`
`261`	`286`	`{`
`262`		`- return new Api\Milestones($this);`
	`287`	`+ return new Milestones($this);`
`263`	`288`	`}`
`264`	`289`
`265`	`290`	`/**`
`266`	`291`	`* @return Api\ProjectNamespaces`
`267`	`292`	`*/`
`268`	`293`	`public function namespaces()`
`269`	`294`	`{`
`270`		`- return new Api\ProjectNamespaces($this);`
	`295`	`+ return new ProjectNamespaces($this);`
`271`	`296`	`}`
`272`	`297`
`273`	`298`	`/**`
`274`	`299`	`* @return Api\Projects`
`275`	`300`	`*/`
`276`	`301`	`public function projects()`
`277`	`302`	`{`
`278`		`- return new Api\Projects($this);`
	`303`	`+ return new Projects($this);`
`279`	`304`	`}`
`280`	`305`
`281`	`306`	`/**`
`282`	`307`	`* @return Api\Repositories`
`283`	`308`	`*/`
`284`	`309`	`public function repositories()`
`285`	`310`	`{`
`286`		`- return new Api\Repositories($this);`
	`311`	`+ return new Repositories($this);`
`287`	`312`	`}`
`288`	`313`
`289`	`314`	`/**`
`290`	`315`	`* @return Api\RepositoryFiles`
`291`	`316`	`*/`
`292`	`317`	`public function repositoryFiles()`
`293`	`318`	`{`
`294`		`- return new Api\RepositoryFiles($this);`
	`319`	`+ return new RepositoryFiles($this);`
`295`	`320`	`}`
`296`	`321`
`297`	`322`	`/**`
`298`	`323`	`* @return Api\Schedules`
`299`	`324`	`*/`
`300`	`325`	`public function schedules()`
`301`	`326`	`{`
`302`		`- return new Api\Schedules($this);`
	`327`	`+ return new Schedules($this);`
`303`	`328`	`}`
`304`	`329`
`305`	`330`	`/**`
`306`	`331`	`* @return Api\Snippets`
`307`	`332`	`*/`
`308`	`333`	`public function snippets()`
`309`	`334`	`{`
`310`		`- return new Api\Snippets($this);`
	`335`	`+ return new Snippets($this);`
`311`	`336`	`}`
`312`	`337`
`313`	`338`	`/**`
`314`	`339`	`* @return Api\SystemHooks`
`315`	`340`	`*/`
`316`	`341`	`public function systemHooks()`
`317`	`342`	`{`
`318`		`- return new Api\SystemHooks($this);`
	`343`	`+ return new SystemHooks($this);`
`319`	`344`	`}`
`320`	`345`
`321`	`346`	`/**`
`322`	`347`	`* @return Api\Users`
`323`	`348`	`*/`
`324`	`349`	`public function users()`
`325`	`350`	`{`
`326`		`- return new Api\Users($this);`
	`351`	`+ return new Users($this);`
`327`	`352`	`}`
`328`	`353`
`329`	`354`	`/**`
`330`	`355`	`* @return Api\Tags`
`331`	`356`	`*/`
`332`	`357`	`public function tags()`
`333`	`358`	`{`
`334`		`- return new Api\Tags($this);`
	`359`	`+ return new Tags($this);`
`335`	`360`	`}`
`336`	`361`
`337`	`362`	`/**`
`338`	`363`	`* @return Api\Version`
`339`	`364`	`*/`
`340`	`365`	`public function version()`
`341`	`366`	`{`
`342`		`- return new Api\Version($this);`
	`367`	`+ return new Version($this);`
`343`	`368`	`}`
`344`	`369`
`345`	`370`	`/**`
`346`	`371`	`* @return Api\Wiki`
`347`	`372`	`*/`
`348`	`373`	`public function wiki()`
`349`	`374`	`{`
`350`		`- return new Api\Wiki($this);`
	`375`	`+ return new Wiki($this);`
`351`	`376`	`}`
`352`	`377`
`353`	`378`	`/**`
Original file line number	Diff line number	Diff line change
`@@ -167,11 +167,7 @@ protected function postFetch()`
`167`	`167`	`{`
`168`	`168`	`$response = $this->client->getLastResponse();`
`169`	`169`
`170`		`- if (null === $response) {`
`171`		`- $this->pagination = [];`
`172`		`- } else {`
`173`		`- $this->pagination = ResponseMediator::getPagination($response);`
`174`		`- }`
	`170`	`+ $this->pagination = null === $response ? [] : ResponseMediator::getPagination($response);`
`175`	`171`	`}`
`176`	`172`
`177`	`173`	`/**`
Original file line number	Diff line number	Diff line change
`@@ -48,15 +48,12 @@ protected function getAbstractApiMock(array $methods = [])`
`48`	`48`	`;`
`49`	`49`	`$client = Client::createWithHttpClient($httpClient);`
`50`	`50`
`51`		`- $abstractApiMock = $this->getMockBuilder('Gitlab\Api\AbstractApi')`
	`51`	`+ return $this->getMockBuilder('Gitlab\Api\AbstractApi')`
`52`	`52`	`->setConstructorArgs([`
`53`	`53`	`$client,`
`54`	`54`	`null,`
`55`	`55`	`])`
`56`	`56`	`->setMethods($methods)`
`57`		`- ->getMockForAbstractClass()`
`58`		`- ;`
`59`		`-`
`60`		`- return $abstractApiMock;`
	`57`	`+ ->getMockForAbstractClass();`
`61`	`58`	`}`
`62`	`59`	`}`