Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

An evaluator using onnxscript API to build graph using torchscript (we will have our own graph to replace torchscript.) #1

Open
GitHub2Janky opened this issue Jun 15, 2024 · 2 comments

Comments

@GitHub2Janky
Copy link
Owner

An evaluator using onnxscript API to build graph using torchscript (we will have our own graph to replace torchscript.)

works with pytorch/pytorch#92717

  1. Op object triggers graph_eval instead of eval to begin op insertion for the graph (Need to figure out how to keep both functionality if they need to stay on the same API.)
  2. TorchscriptEvaluator serves as a manager of input/output graph. In this demo, both of them are torchscript, so this class seems simple (should be more complicated depending on ONNX graph builder API and format requirements).
  3. tensor.py is not modified because onnxscript does not really use the graph value. That is, it will only have to be compatible with graph builder type only in the future implementation.

Fixes #273

Co-authored-by: Ti-Tai Wang titaiwang@microsoft.com

Originally posted by @justinchuby in microsoft/onnxscript#336

@GitHub2Janky
Copy link
Owner Author

7000

@GitHub2Janky
Copy link
Owner Author

#273

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant