Skip to content

Adjust button bottoms for UIFont descender #67

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 29, 2018
Merged

Adjust button bottoms for UIFont descender #67

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions MessageViewController/MessageView.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -272,10 +272,14 @@ public final class MessageView: UIView, MessageTextViewListener {
let textViewHeight = self.textViewHeight
let textViewMaxY = textViewY + textViewHeight

// adjust for font descender so button aligns with the text baseline
let descenderAdjustment = floor(textView.font?.descender ?? 0)
let buttonYStarter = textViewMaxY - textViewInset.bottom - descenderAdjustment

// adjust by bottom offset so content is flush w/ text view
let leftButtonFrame = CGRect(
x: safeBounds.minX + leftButtonInset,
y: textViewMaxY - leftButtonSize.height + leftButton.bottomHeightOffset - textViewInset.bottom,
y: buttonYStarter - leftButtonSize.height + leftButton.bottomHeightOffset,
width: leftButtonSize.width,
height: leftButtonSize.height
)
Expand All @@ -293,7 +297,7 @@ public final class MessageView: UIView, MessageTextViewListener {
// adjust by bottom offset so content is flush w/ text view
let rightButtonFrame = CGRect(
x: textViewFrame.maxX,
y: textViewMaxY - rightButtonSize.height + rightButton.bottomHeightOffset - textViewInset.bottom,
y: buttonYStarter - rightButtonSize.height + rightButton.bottomHeightOffset,
width: rightButtonSize.width,
height: rightButtonSize.height
)
Expand Down