Skip to content

Add a11y labels to the send button #57

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 14, 2018
Merged

Add a11y labels to the send button #57

merged 1 commit into from
Apr 14, 2018

Conversation

BasThomas
Copy link
Collaborator

@BasThomas BasThomas commented Apr 14, 2018

Fixes #56

For reference:

Yeah, the only tricky thing is that at that point they would always be tied to the information passed into the function — if someone would want a different accessibilityLabel than the title, they would not be able to do so.

So we could add an optional parameter that would override the accessibilityLabel, just not sure if that's scalable enough / overkill.

@BasThomas
Copy link
Collaborator Author

What do you think @lenkaiser @rnystrom @gingerbeardman?

@lenkaiser lenkaiser merged commit 1b0e55a into master Apr 14, 2018
@gingerbeardman
Copy link

I think this is good, let's see what the future holds no point overthinking it at this point.

@BasThomas BasThomas deleted the send-a11y branch April 14, 2018 20:02
BasThomas added a commit that referenced this pull request Apr 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants