Skip to content

Commit 8d5a312

Browse files
authored
chore(api): clean up compiler/testing api (angular#9520)
Do not export MockXHR, which is a private helper.
1 parent 8eb81b3 commit 8d5a312

File tree

5 files changed

+4
-12
lines changed

5 files changed

+4
-12
lines changed

modules/@angular/compiler/test/directive_normalizer_spec.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ import {CompileTemplateMetadata, CompileTypeMetadata} from '@angular/compiler/sr
1010
import {CompilerConfig} from '@angular/compiler/src/config';
1111
import {DirectiveNormalizer} from '@angular/compiler/src/directive_normalizer';
1212
import {XHR} from '@angular/compiler/src/xhr';
13-
import {MockXHR} from '@angular/compiler/testing';
13+
import {MockXHR} from '@angular/compiler/testing/xhr_mock';
1414
import {ViewEncapsulation} from '@angular/core/src/metadata/view';
1515
import {beforeEach, beforeEachProviders, ddescribe, describe, expect, iit, inject, it, xit} from '@angular/core/testing/testing_internal';
1616
import {AsyncTestCompleter} from '@angular/core/testing/testing_internal';

modules/@angular/compiler/test/test_bindings.ts

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,8 @@
88

99
import {ElementSchemaRegistry, UrlResolver, XHR} from '@angular/compiler';
1010
import {createUrlResolverWithoutPackagePrefix} from '@angular/compiler/src/url_resolver';
11-
import {MockSchemaRegistry, MockXHR} from '@angular/compiler/testing';
11+
import {MockSchemaRegistry} from '@angular/compiler/testing';
12+
import {MockXHR} from '@angular/compiler/testing/xhr_mock';
1213

1314
export var TEST_PROVIDERS: any[] = [
1415
{provide: ElementSchemaRegistry, useValue: new MockSchemaRegistry({}, {})},

modules/@angular/compiler/test/xhr_mock_spec.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@
88

99
import {beforeEach, ddescribe, describe, expect, iit, inject, it,} from '@angular/core/testing/testing_internal';
1010
import {AsyncTestCompleter} from '@angular/core/testing/testing_internal';
11-
import {MockXHR} from '@angular/compiler/testing';
11+
import {MockXHR} from '@angular/compiler/testing/xhr_mock';
1212
import {PromiseWrapper} from '../src/facade/async';
1313
import {isPresent} from '../src/facade/lang';
1414

modules/@angular/compiler/testing.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,5 @@
88

99
export * from './testing/schema_registry_mock';
1010
export * from './testing/view_resolver_mock';
11-
export * from './testing/xhr_mock';
1211
export * from './testing/test_component_builder';
1312
export * from './testing/directive_resolver_mock';

tools/public_api_guard/compiler/testing.d.ts

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -51,14 +51,6 @@ export declare class MockViewResolver extends ViewResolver {
5151
resolve(component: Type): ViewMetadata;
5252
}
5353

54-
export declare class MockXHR extends XHR {
55-
get(url: string): Promise<string>;
56-
expect(url: string, response: string): void;
57-
when(url: string, response: string): void;
58-
flush(): void;
59-
verifyNoOutstandingExpectations(): void;
60-
}
61-
6254
export declare class TestComponentBuilder {
6355
constructor(_injector: Injector);
6456
overrideTemplate(componentType: Type, template: string): TestComponentBuilder;

0 commit comments

Comments
 (0)