Nickname not present anymore

[plainerman]

According to #190, @JaapAntwerp posted:

The only thing still missing (which was there in the previous versions) is the "nickname" of the contact added to the body (as I have an extended family, sometimes in the "nickname" I have put information who is who. eg. "daughter of ...". or "son of .....")

If this was working in the past, we should reenable it.

[JaapAntwerp]

Could it be linked to this:

GoogleContactsEventsNotifier/code.gs

Lines 401 to 409 in 7e657a9

	try {
	self.contactId = googleContact.resourceName;
	// Contact identification data.
	self.data.merge(new ContactDataDC(
	googleContact.names[0].displayName, // Name.
	googleContact.givenName, // Nickname.
	null // Profile image URL.
	));

[plainerman]

Yes, it probably has to do with this line or at least it is a good starting point to debug.
If you (or anybody else) want(s), you can look into this issue and create a PR. I am here to answer questions.

If you don't want to I'll probably only find time over the holidays to look into this issue.

[JaapAntwerp]

Dear Michael, I have absolutely no knowledge about IT Even the implementation of the script is every time a struggle for me. So I hope that you (or one of the other monitors) can find a solution to these problems. Best regards Jaap Antwerp - Belgium Op di 6 dec. 2022 07:37 schreef Michael Plainer ***@***.***>:

…

Yes, it probably has to do with this line or at least it is a good starting point to debug. If you (or anybody else) want(s), you can look into this issue and create a PR. I am here to answer questions. If you don't want to I'll probably only find time over the holidays to look into this issue. — Reply to this email directly, view it on GitHub <#192 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AKBW323PPTU6WCDUQPLUOV3WL3NJHANCNFSM6AAAAAASP322EI> . You are receiving this because you were mentioned.Message ID: ***@***.***>

[plainerman]

Hey @JaapAntwerp no worries, we are already grateful that you bring this to our attention.
But since I am currently the only maintainer and do this in my spare time I cannot guarantee you when I find the time to fix it. Be assured that it is on my to-do list ;).

I marked it as open if anybody else stumbles upon this issue and wants to fix it sooner than I'll find the time.

[JaapAntwerp]

Hi Michael, Something else.... Is there a way how to see which script has sent which email? I have now various scripts (some of them the sale version), but find it difficult to see which result (email) comes from which script. Is there a code that gives (e.g.) the script name? Same question (more or less), is there a way to see which scripts are actually active and which ones are on hold? Thanks Have a great Silvester evening Jaap Op do 29 dec. 2022 12:16 schreef Michael Plainer ***@***.***>:

…

Hey @JaapAntwerp <https://github.com/JaapAntwerp> no worries, we are already grateful that you bring this to our attention. But since I am currently the only maintainer and do this in my spare time I cannot guarantee you when I find the time to fix it. But be assured that it is on my to-do list. — Reply to this email directly, view it on GitHub <#192 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AKBW327BUJUOQPZPKZ2NYWTWPVXI5ANCNFSM6AAAAAASP322EI> . You are receiving this because you were mentioned.Message ID: ***@***.***>

[plainerman]

I don't think that we will add support for this.

But the easiest way for you is to add one of these lines in the script

GoogleContactsEventsNotifier/code.gs

Lines 2440 to 2444 in 7e657a9

	bodyPrefix = _('Hey! Don\'t forget these events') + ':';
	bodySuffixes = [
	_('Google Contacts Events Notifier') + ' (' + _('version') + ' ' + version.toString() + ')',
	_('It looks like you are using an outdated version of this script') + '.',
	_('You can find the latest one here')

For example you can change 'Google Contacts Events Notifier' to 'Google Contacts Events Notifier (Google Account1)'. If you use a different language, just change a string in your language settings.

For example if you use German use something here:

GoogleContactsEventsNotifier/code.gs

Lines 1359 to 1389 in 7e657a9

	'de': {
	'Age': 'Alter',
	'Years': 'Jahre',
	'Events': 'Termine',
	'Birthdays today': 'Geburtstage heute',
	'Birthdays tomorrow': 'Geburtstage morgen',
	'Birthdays in {0} days': 'Geburtstage in {0} Tagen',
	'Anniversaries today': 'Jahrestage heute',
	'Anniversaries tomorrow': 'Jahrestage morgen',
	'Anniversaries in {0} days': 'Jahrestage in {0} Tagen',
	'Custom events today': 'Benutzerdefinierte Termine heute',
	'Custom events tomorrow': 'Benutzerdefinierte Termine morgen',
	'Custom events in {0} days': 'Benutzerdefinierte Termine in {0} Tagen',
	'Hey! Don\'t forget these events': 'Hey! Vergiss diese Termine nicht',
	'version': 'Version',
	'dd-MM-yyyy': 'dd-MM-yyyy',
	'Mobile phone': 'Telefon (mobil)',
	'Work phone': 'Telefon (geschäftlich)',
	'Home phone': 'Telefon (privat)',
	'Main phone': 'Telefon (haupt)',
	'Other phone': 'Telefon (sonstige)',
	'Home fax': 'Fax (privat)',
	'Work fax': 'Fax (geschäftlich)',
	'Google voice': 'Google Voice',
	'Pager': 'Pager',
	'Home email': 'E-Mail (privat)',
	'Work email': 'E-Mail (geschäftlich)',
	'Other email': 'E-Mail (sonstige)',
	'It looks like you are using an outdated version of this script': 'Du verwendest anscheinend eine veraltete Version dieses Skripts',
	'You can find the latest one here': 'Du findest die neuste Version hier', // Using feminime version of 'latest', because it refers to 'version'. There's possibility it won't fit into diffrent context.
	},

[JaapAntwerp]

Thanks Michael. I will try that 👍 And indeed it was not my intention to get a script change. But it was to learn something myself and to get organised myself Thanks again for your suggestions I will try them Jaap Op za 31 dec. 2022 12:13 schreef Michael Plainer ***@***.***>:

…

I don't think that we will add support for this. But the easiest way for you is to add one of these lines in the script https://github.com/GioBonvi/GoogleContactsEventsNotifier/blob/7e657a9e606f449fef22feae68d448d11083122b/code.gs#L2440-L2444 For example you can change 'Google Contacts Events Notifier' to 'Google Contacts Events Notifier (Google Account1)'. If you use a different language, just change a string in your language settings. For example if you use German use something here: https://github.com/GioBonvi/GoogleContactsEventsNotifier/blob/7e657a9e606f449fef22feae68d448d11083122b/code.gs#L1359-L1389 — Reply to this email directly, view it on GitHub <#192 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AKBW325TKIIVYI4Y3M27YRTWQAIONANCNFSM6AAAAAASP322EI> . You are receiving this because you were mentioned.Message ID: ***@***.***>

[JaapAntwerp]

hi Michael, Is there a way I can contact you privately (so I show you some results with private details) Obviously I don't want these private details on the GitHub website ;-) Groeten, Jaap Op wo 30 nov. 2022 om 18:19 schreef Michael Plainer < ***@***.***>:

…

According to #190 <#190>, @JaapAntwerp <https://github.com/JaapAntwerp> posted: The only thing still missing (which was there in the previous versions) is the "nickname" of the contact added to the body (as I have an extended family, sometimes in the "nickname" I have put information who is who. eg. "daughter of ...". or "son of .....") If this was working in the past, we should reenable it. — Reply to this email directly, view it on GitHub <#192>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AKBW32ZGFBHSJFUUFZXQKNLWK6EC3ANCNFSM6AAAAAASP322EI> . You are receiving this because you were mentioned.Message ID: ***@***.***>

[JaapAntwerp]

What I don't understand is: - I took an old verssion (5.0.1, which was still with nicknames, etc.) which works fine for my general account. - Then I did copy-paste from this general account to the gmail script accounts for the various branches of my families, changed the "googleEmail", "notificationEmail" and the "emailSenderName" - and now in some of the accounts it works again fine (as it should, it was only a copy-paste), but in some accounts it fails to calculate the age and leaves out again the nickname. I have double checked and in all accounts I have activated the API service Calendar and People: [image: image.png] Why would it work in one account and not in another???? Groeten, Jaap ps, could this mean that some of my scripts are moved to V8 (and thus the old versions don't work anymore), and some of them are this in Rhino?????? This script has been successfully migrated from Rhino to V8 runtime on ..... Op wo 4 jan. 2023 om 11:10 schreef Jaap Antwerp ***@***.***>:

…

hi Michael, Is there a way I can contact you privately (so I show you some results with private details) Obviously I don't want these private details on the GitHub website ;-) Groeten, Jaap Op wo 30 nov. 2022 om 18:19 schreef Michael Plainer < ***@***.***>: > According to #190 > <#190>, > @JaapAntwerp <https://github.com/JaapAntwerp> posted: > > The only thing still missing (which was there in the previous versions) > is the "nickname" of the contact added to the body (as I have an extended > family, sometimes in the "nickname" I have put information who is who. eg. > "daughter of ...". or "son of .....") > > If this was working in the past, we should reenable it. > > — > Reply to this email directly, view it on GitHub > <#192>, > or unsubscribe > <https://github.com/notifications/unsubscribe-auth/AKBW32ZGFBHSJFUUFZXQKNLWK6EC3ANCNFSM6AAAAAASP322EI> > . > You are receiving this because you were mentioned.Message ID: > ***@***.***> >

[JaapAntwerp]

I see 3 errors in the 5.1.4 version:

1. the "nickname" is no longer presented in the body

2. the "Anniversaries" are not shown in a separate group anymore, but in "custom events"

3. the "notificationBlacklist" events are no longer filtered out, but shown anyway (the "notificationBlacklist" doesn't work anymore)