Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Split the Asrt type #159

Open
Tracked by #83
giltho opened this issue Nov 4, 2022 · 0 comments
Open
Tracked by #83

Split the Asrt type #159

giltho opened this issue Nov 4, 2022 · 0 comments
Assignees
@NatKarmios
Labels
cleanup
Milestone
Tech debt catchup...

Comments

@giltho
Copy link
Contributor

giltho commented Nov 4, 2022

The Asrt.t type weird, an assertion is actually a free monoid of "Simple assertions", and the representations are mixed.
I'd like to split that type into

type simple =
   | GA of ...
   | Pure of ...
   ... 


type t = simple list

It would avoid weird cases in the code where the assertions are split and then the Star pattern is ignored

It would also be a great time to rename GA to CorePred
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@NatKarmios NatKarmios

Labels
cleanup
Projects
None yet
Milestone
Tech debt catchup 2022/23
Development

No branches or pull requests
2 participants
@giltho @NatKarmios