Skip to content
This repository has been archived by the owner on May 23, 2022. It is now read-only.

Discuss, document and enforce version numbering routines #2

Closed
albbas opened this issue Mar 11, 2021 · 9 comments
Closed

Discuss, document and enforce version numbering routines #2

albbas opened this issue Mar 11, 2021 · 9 comments
Assignees

Comments

@albbas
Copy link
Contributor

albbas commented Mar 11, 2021

When building the mobile speller for divvun.org, the compilation fails

./configure --without-forrest --enable-spellers --disable-hfst-desktop-spellers --prefix=$HOME/.local --enable-hfst-mobile-speller

/usr/bin/hfst-lexc: The file lexicon.tmp.lexc did not compile cleanly.

@Trondtr
Copy link
Contributor

Trondtr commented Mar 11, 2021

For documentation:
Warning: Sublexicons defined but not used
PROP-PATR-MAL_END-IN-CH/DZ
*** ERROR: could not parse lexc file: treating warnings as errors [--Werror] ***

Commenting out the unused lexicon, checked in revision , now it compiles..

@Trondtr Trondtr closed this as completed Mar 11, 2021
@snomos
Copy link
Contributor

snomos commented Mar 11, 2021

Chiara fekk same feil i mdf på måndag (jf https://giella.zulipchat.com/#narrow/stream/238727-mdf/topic/Kompilering.20feil) - det viste seg at ho ikkje hadde oppdatert giella-shared. Kan det vera tilfelle her òg? @Trondtr @albbas ?

@albbas
Copy link
Contributor Author

albbas commented Mar 11, 2021

Stemmer det.

@albbas albbas transferred this issue from giellalt/lang-myv Mar 11, 2021
@albbas albbas reopened this Mar 11, 2021
@albbas
Copy link
Contributor Author

albbas commented Mar 11, 2021

Setup version dependency á la giella-core. If it exists, use it actively to avoid unnecessary issues like this.

@Trondtr
Copy link
Contributor

Trondtr commented Mar 11, 2021

Eg ser at feilen er at eg hadde ei uinsjekka linje i giella-shared, slik at det ikkje vart oppdatert. Eg fiksar det no, og sannsynlegvis betyr det at eg skal sjekke inn leksikona på nytt.

@Trondtr
Copy link
Contributor

Trondtr commented Mar 11, 2021

No har eg oppdatert giella-shared (det var ei endring eg ikkje hadde sjekka inn som stoppa gut, så eg hadde ikkje siste verjson) og eg har kommentert inn att dei problematiske leksikona i mdf, mhr, myv. fst-ane kompilerer, no også med dei siste namna.

@snomos snomos changed the title Does not compile Add giella-core like version check Mar 24, 2021
@snomos
Copy link
Contributor

snomos commented Mar 24, 2021

One question is whether it would be better to split this repository into multiple ones, one for each top level subdir. It will increase the number of dependencies for each language repository, but would restrict the dependencies to only the relevant parts.

@snomos
Copy link
Contributor

snomos commented Mar 24, 2021

One question is whether it would be better to split this repository into multiple ones, one for each top level subdir. It will increase the number of dependencies for each language repository, but would restrict the dependencies to only the relevant parts.

Thinking more about this, I believe it is not a good idea. It will lead to dependency and thus maintenance hell.

There is already a version check mechanism in place. But it must be used and enforced. So what we need is a receipt for when and how to increase version numbers both here and in the dependent repositories.

@snomos snomos changed the title Add giella-core like version check Discuss, document and enforce version numbering routines Mar 26, 2021
@snomos
Copy link
Contributor

snomos commented May 12, 2022

One question is whether it would be better to split this repository into multiple ones, one for each top level subdir. It will increase the number of dependencies for each language repository, but would restrict the dependencies to only the relevant parts.

Thinking more about this, I believe it is not a good idea. It will lead to dependency and thus maintenance hell.

Thinking even more, and discussing with others, it was concluded that this was indeed a good idea. See giellalt/giella-core#20 .

I will close this issue now as resolved.

@snomos snomos closed this as completed May 12, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants