Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

352 MIDI chorales after discarding voice divisions #62

Closed
asdfang opened this issue Nov 18, 2019 · 2 comments
Closed

352 MIDI chorales after discarding voice divisions #62

asdfang opened this issue Nov 18, 2019 · 2 comments

Comments

@asdfang
Copy link

asdfang commented Nov 18, 2019

Hi!

How can I recreate the 352 MIDI chorales after discarding ones with voice divisions? Are these readily available online or from the code? If not, could you point me to the set of 389 MIDI files that you originally started with? I've been searching online and am not sure which one is the reliable one that you used, as some don't have fermata information in them.

Update: I grabbed MIDIs from this repo, and retrieved chorales indexed by Kalmus, as your DeepBach paper suggests. (Aside for anyone else trying to recreate this: in their files.txt, there are 419 non-empty entries for Kalmus catalog numbers, but of those 419, there are only 395 that have valid corresponding file names in the directory.)
Of those 395, I parsed with music21.converter.parse and kept only those with 4 parts, and the number remaining was 352. I hope this isn't a coincidence!

Unfortunately, these still don't have fermata information, so I'm still wondering about your original process!

Thanks!

@asdfang asdfang changed the title 352 chorales after discarding voice divisions 352 MIDI chorales after discarding voice divisions Nov 18, 2019
@Ghadjeres
Copy link
Owner

Hi,
I used the chorales included in music21!
Check music21.corpus.chorales https://web.mit.edu/music21/doc/moduleReference/moduleCorpusChorales.html

@asdfang
Copy link
Author

asdfang commented Nov 21, 2019

Ah, thanks so much!
From your code, it looks like you use the default music21.corpus.Iterator, which defaults to the Riemenschneider numbering system. So from those 371 chorales, I filtered for chorales who only had 4 music21.stream.Parts and resulted in 351. This is obviously the slightest difference from the 352 that you generate in your paper – not sure if I'm filtering the same way that you did (how to detect voice divisions?) or music21's corpus has been modified slightly.

Update: nevermind, I found the is_valid method in chorale_dataset.py. Thanks for your help!

@asdfang asdfang closed this as completed Nov 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants