Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Invisibility Plugins For Java Players Not Hiding Them From Bedrock Players #2209

Open
KantoKairyu opened this issue May 13, 2021 · 17 comments
Open
Labels
Priority: Low Question A question about something.

Comments

@KantoKairyu
Copy link

Describe the bug

I'm using PremiumVanish on a spigot server, my players can appear invisible in the tablist but not in-game, recently bedrock players have pointed out that they can see these players in the bedrock playerlist even when they are meant to be invisible.

To Reproduce

Use 'PremiumVanish'

Set it so players can appear invisible in all aspects except in direct eyeline visibility

Check playerllist on java by pressing tab - They will not show

Check playerlist on Bedrock, they will appear there on the sidebar

Expected behaviour

I was hoping they would appear offline for bedrock players much the same way they do for Java

Screenshots / Videos

No response

Server Version and Plugins

Spigot

Geyser Dump

No response

Geyser Version

.2.1-SNAPSHOT (git-master-7dc9c03)

Minecraft: Bedrock Edition Version

Bedrock: 1.16.100/1.16.101 - 1.16.220

Additional Context

The problem isn't too difficult, I have also had reports of anvils not working right for my bedrock players but I can't be too sure as I haven't had time to check myself, but yeah, amazing amazing plugin, it would be great though if hidden players from the Java tablist were also hidden to Bedrock players.

@Camotoy
Copy link
Member

Camotoy commented May 13, 2021

Unfortunately, as PremiumVanish is... well... premium, we can't test this locally to fix it. If you find a free alternative that exhibits the same issue, please post it here.

@KantoKairyu
Copy link
Author

Darn, thank you for the quick reply time. there is a non-premium version but it also lacks the ability to hide the player in tab so I don't suppose that would be good for testing but in case it is: https://www.spigotmc.org/resources/supervanish-be-invisible.1331/

Is there an invis plugin you know works with geyser for tablist?

Also serious thanks for this plugin, my YT community is able to all play together thanks to the bedrock Java gap being bridged :)

@Camotoy
Copy link
Member

Camotoy commented May 13, 2021

We use that plugin on our public "testing" server. The Spigot description says it hides invisible players in the player list?

@KantoKairyu
Copy link
Author

True but it's the tab list that is hidden in the premium I believe, I think supervanish only greys out their names?

@Camotoy
Copy link
Member

Camotoy commented May 13, 2021

That I am not sure of.

@KantoKairyu
Copy link
Author

Hmm, it's 10 euros, if you'd like I can buy it for you, it seems to be a popular invis plugin and I know it's not a traditional donation but if it helps you guys make geyser even better then I'd be happy to do so.

@SupremeMortal
Copy link
Member

@S0M0G Thanks for helping us but you are breaking the terms of service for the plugin by redistributing it so I have removed the message.

@GeyserMC GeyserMC deleted a comment from S0M0G May 16, 2021
@S0M0G
Copy link

S0M0G commented May 16, 2021

But i bought it for you guys, and I'm not planning on using it, so can I somehow send it privately?

@KantoKairyu
Copy link
Author

It's really nice of you but I think purchasing it sorta locks you into legally agreeing it's for your own use and not for sharing :( Thanks bunch though man, the gesture was really kind :)

@KantoKairyu
Copy link
Author

Also update: On my alt I can play on bedrock and see what happens when I toggle invis on and off, I disappear from one of the playerlist menus and stay on the other. It's hard to describe but you know the way there's one player list with profile pictures and another with a standard logo? Well my invis players do indeed vansh from the list with their profile pics but they stay on the other playerlist...

@NFLD99
Copy link

NFLD99 commented Jul 2, 2021

if @LeonMangler cant/wont provide a copy for testing i can see if i cant buy a copy for you @Camotoy or just paypal you the $ for it so we can get this fixed

@Camotoy
Copy link
Member

Camotoy commented Jul 2, 2021

Well my invis players do indeed vansh from the list with their profile pics but they stay on the other playerlist...

This just stuck out to me. I think the issue doesn't lie in the player list but something with our scoreboard system instead.

@LeonMangler
Copy link

LeonMangler commented Jul 7, 2021

Hey, I'll give free PV access to anyone who works on geyser, please just provide your Spigot names. I've just given access to Camotoy.

According to Camotoy in #2340 the issue with vanished players appearing in the bedrock serverlist playercount can be fixed with Geyser's legacy-ping-passthrough option.

As for the in-game tablist, with the default config PV strips players from PlayerInfo packets with ProtocolLib and uses Spigot's hidePlayer() mechanism. It doesn't remove them from ScoreboardTeam packets by default, since that caused issues with nametag plugins and vanished players not having nametags in the past. It can be enabled in the config though (By removing "ScoreboardTeam" from "DisabledInvisibilityModules"). PV doesn't have any packet listeners bungee-sided.

If we can get it to work with SuperVanish, which is free, open-source and does hide vanished players in the tablist to everyone who doesn't have the right permissions, it should also work with PV. SV also uses Spigot's hidePlayer() mechanism and removes vanished players from Player Info packets spigot-sided with ProtocolLib.

@Camotoy
Copy link
Member

Camotoy commented Jul 7, 2021

It doesn't remove them from ScoreboardTeam packets by default, since that caused issues with nametag plugins and vanished players not having nametags in the past. It can be enabled in the config though (By removing "ScoreboardTeam" from "DisabledInvisibilityModules").

Interesting - so I wonder if the behavior is intentional to a degree (at least in the way we handle scoreboard team packets)? I'd ask anyone affected if they could try the steps LeonMangler proposes and see if it fixes the "tab list" issue for them.
Thanks for the plugin access. I'll try to look into the issue soon.

@NFLD99
Copy link

NFLD99 commented Jul 7, 2021

Hey, I'll give free PV access to anyone who works on geyser, please just provide your Spigot names. I've just given access to Camotoy.

According to Camotoy in #2340 the issue with vanished players appearing in the bedrock serverlist playercount can be fixed with Geyser's legacy-ping-passthrough option.

As for the in-game tablist, with the default config PV strips players from PlayerInfo packets with ProtocolLib and uses Spigot's hidePlayer() mechanism. It doesn't remove them from ScoreboardTeam packets by default, since that caused issues with nametag plugins and vanished players not having nametags in the past. It can be enabled in the config though (By removing "ScoreboardTeam" from "DisabledInvisibilityModules"). PV doesn't have any packet listeners bungee-sided.

If we can get it to work with SuperVanish, which is free, open-source and does hide vanished players in the tablist to everyone who doesn't have the right permissions, it should also work with PV. SV also uses Spigot's hidePlayer() mechanism and removes vanished players from Player Info packets spigot-sided with ProtocolLib.

It doesn't remove them from ScoreboardTeam packets by default, since that caused issues with nametag plugins and vanished players not having nametags in the past. It can be enabled in the config though (By removing "ScoreboardTeam" from "DisabledInvisibilityModules").

Interesting - so I wonder if the behavior is intentional to a degree (at least in the way we handle scoreboard team packets)? I'd ask anyone affected if they could try the steps LeonMangler proposes and see if it fixes the "tab list" issue for them.
Thanks for the plugin access. I'll try to look into the issue soon.

Great News! using those setting it fixed it! [havnt noticed any side effects so far either ]

@Camotoy
Copy link
Member

Camotoy commented Jan 18, 2022

NEZNAMY reached out to me after NEZNAMY/TAB#454 - the good news is that this behavior should be the same when a player disconnects normally. In that way, it is indeed like the player vanished. But, we should still not be showing these tab entries if the player isn't logged on.

@Tim203
Copy link
Member

Tim203 commented Oct 8, 2024

Does this still happen with the latest build (685)?

@Tim203 Tim203 added the Question A question about something. label Oct 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority: Low Question A question about something.
Projects
Development

No branches or pull requests

7 participants